You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/14 12:41:17 UTC
[GitHub] [pulsar] tjiuming opened a new pull request, #17089: [DONT_MERGE][doc][monitoring][metadata] batch metadata store metrics doc
tjiuming opened a new pull request, #17089:
URL: https://github.com/apache/pulsar/pull/17089
### Motivation
doc for https://github.com/apache/pulsar/pull/17072
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#discussion_r1013742703
##########
site2/docs/reference-metrics.md:
##########
@@ -605,16 +605,19 @@ All the web service executor metrics are labeled with the following labels:
### Metadata store metrics
-All the metadata store metrics are labelled with the following labels:
+All the metadata store metrics are labeled with the following labels:
- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you configured in `broker.conf`.
- *name*: `name=${metadata-store|configuration-metadata-store|state-metadata-store}`. `${name}` is the metadata store name.
-| Name | Type | Description |
-|----------------------------------------|-----------|----------------------------------------------------------------------------------------------|
-| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
-| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
-
+| Name | Type | Description |
+|----------------------------------------------------|-----------|----------------------------------------------------------------------------------------------|
+| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
Review Comment:
it means that
1. the latency of getting data from metadata store
2. the latency of deleting data from metadata store
3. the latency of putting data to metadata store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#issuecomment-1312960309
Hi @asafm @codelipenghui
could you please review this PR from a technical perspective? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on a diff in pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
asafm commented on code in PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#discussion_r1021611586
##########
site2/docs/reference-metrics.md:
##########
@@ -605,16 +605,19 @@ All the web service executor metrics are labeled with the following labels:
### Metadata store metrics
-All the metadata store metrics are labelled with the following labels:
+All the metadata store metrics are labeled with the following labels:
- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you configured in `broker.conf`.
- *name*: `name=${metadata-store|configuration-metadata-store|state-metadata-store}`. `${name}` is the metadata store name.
-| Name | Type | Description |
-|----------------------------------------|-----------|----------------------------------------------------------------------------------------------|
-| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
-| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
-
+| Name | Type | Description |
+|----------------------------------------------------|-----------|----------------------------------------------------------------------------------------------|
+| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data from/to metadata store. |
+| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
+| pulsar_batch_metadata_store_executor_queue_size | Gauge | The number of blocking operations in metadata store executor. |
+| pulsar_batch_metadata_store_queue_wait_time_ms | Histogram | The waiting time of batch operations. |
+| pulsar_batch_metadata_store_batch_execute_time_ms | Histogram | The time of the batch execution in milliseconds. |
Review Comment:
`the time of` --> `the duration of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #17089:
URL: https://github.com/apache/pulsar/pull/17089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#discussion_r1014930181
##########
site2/docs/reference-metrics.md:
##########
@@ -605,16 +605,19 @@ All the web service executor metrics are labeled with the following labels:
### Metadata store metrics
-All the metadata store metrics are labelled with the following labels:
+All the metadata store metrics are labeled with the following labels:
- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you configured in `broker.conf`.
- *name*: `name=${metadata-store|configuration-metadata-store|state-metadata-store}`. `${name}` is the metadata store name.
-| Name | Type | Description |
-|----------------------------------------|-----------|----------------------------------------------------------------------------------------------|
-| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
-| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
-
+| Name | Type | Description |
+|----------------------------------------------------|-----------|----------------------------------------------------------------------------------------------|
+| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
Review Comment:
Thanks! Can we change it to `The latency of getting/deleting/putting data from/to metadata store.` (delete `fail/success operations` since it brings confusion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#discussion_r1013538839
##########
site2/docs/reference-metrics.md:
##########
@@ -605,16 +605,19 @@ All the web service executor metrics are labeled with the following labels:
### Metadata store metrics
-All the metadata store metrics are labelled with the following labels:
+All the metadata store metrics are labeled with the following labels:
- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you configured in `broker.conf`.
- *name*: `name=${metadata-store|configuration-metadata-store|state-metadata-store}`. `${name}` is the metadata store name.
-| Name | Type | Description |
-|----------------------------------------|-----------|----------------------------------------------------------------------------------------------|
-| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
-| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
-
+| Name | Type | Description |
+|----------------------------------------------------|-----------|----------------------------------------------------------------------------------------------|
+| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
Review Comment:
Sorry, what does `The latency of getting/deleting/putting data fail/success operations from/to metadata store.` this sentence mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#issuecomment-1301968608
@momo-jun @Anonymitaet PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #17089: [doc][monitor]batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#discussion_r1019770293
##########
site2/docs/reference-metrics.md:
##########
@@ -605,16 +605,19 @@ All the web service executor metrics are labeled with the following labels:
### Metadata store metrics
-All the metadata store metrics are labelled with the following labels:
+All the metadata store metrics are labeled with the following labels:
- *cluster*: `cluster=${pulsar_cluster}`. `${pulsar_cluster}` is the cluster name that you configured in `broker.conf`.
- *name*: `name=${metadata-store|configuration-metadata-store|state-metadata-store}`. `${name}` is the metadata store name.
-| Name | Type | Description |
-|----------------------------------------|-----------|----------------------------------------------------------------------------------------------|
-| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
-| pulsar_metadata_store_put_bytes_total | Counter | The number of data put to metadata store. |
-
+| Name | Type | Description |
+|----------------------------------------------------|-----------|----------------------------------------------------------------------------------------------|
+| pulsar_metadata_store_ops_latency | Histogram | The latency of getting/deleting/putting data fail/success operations from/to metadata store. |
Review Comment:
@Anonymitaet OK, I've fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #17089: [draft][doc][monitoring][metadata] batch metadata store metrics doc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17089:
URL: https://github.com/apache/pulsar/pull/17089#issuecomment-1247495906
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org