You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Mete Atamel (Commented) (JIRA)" <ji...@apache.org> on 2012/03/23 13:55:27 UTC
[jira] [Commented] (JCR-2031) Improved log message: include path
[ https://issues.apache.org/jira/browse/JCR-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236550#comment-13236550 ]
Mete Atamel commented on JCR-2031:
----------------------------------
While looking at this for some other bug, I found some issues with this fix. For example, if i create three nested nodes (eg. hello/world/jackrabbit) like this:
Node root = session.getRootNode();
Node hello = root.addNode("hello");
session.save();
Node world = hello.addNode("world");
session.save();
Node jackrabbit = world.addNode("jackrabbit");
session.save();
I see the following in the logs for the three saves:
revision 1 admin@
revision 2 admin@
revision 3 admin@/hello[24]
The problem with this is:
1- Not sure what "admin@" means. I think this should be "admin@ / " to signify that something is written to the root.
2- Even though "world" node was added under "hello" node, it shows up as being added to root in revision 2.
3- Even though "jackrabbit" node was added under "world" node, it shows up as being added to "hello" node in revision 3.
I think the logs should look like this:
revision 1 admin@/
revision 2 admin@/hello[25]
revision 3 admin@/hello[25]/world
> Improved log message: include path
> ----------------------------------
>
> Key: JCR-2031
> URL: https://issues.apache.org/jira/browse/JCR-2031
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: jackrabbit-core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Minor
> Fix For: 1.6
>
> Attachments: JCR-2031.patch, improvedLogMessage.patch
>
>
> The cluster logs a message for each appended operation. The log message is currently the revision number. A more interesting log message would be the user name, and the path of the change (the most specific path if the change contains multiple nodes).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira