[GitHub] [bookkeeper] ivankelly commented on a change in pull request #2764: Ensure progress while restoring from checkpoint.

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #2764:
URL: https://github.com/apache/bookkeeper/pull/2764#discussion_r691097245



##########
File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/rocksdb/checkpoint/CheckpointInfo.java
##########
@@ -128,17 +131,26 @@ public int compareTo(CheckpointInfo o) {
         return this.getCreatedAt().compareTo(o.getCreatedAt());
     }
 
-    public CheckpointMetadata restore(File dbPath, RocksdbRestoreTask task) throws StateStoreException, IOException {
+    public CheckpointMetadata restore(File dbPath, RocksdbRestoreTask task)
+        throws StateStoreException, IOException, TimeoutException {
+
         task.restore(id, metadata);
         updateCurrent(dbPath);
         log.info("Successfully restore checkpoint {} to {}", id, getCheckpointPath(dbPath));
         return metadata;
     }
+    public CheckpointMetadata restore(String dbName, File dbPath, CheckpointStore store)
+        throws StateStoreException, TimeoutException {
+
+        return restore(dbName, dbPath, store, Duration.ofMillis(5));

Review comment:
       5ms is a very small amount of  "idle" time. Gc could easily trigger this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org