You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/13 18:41:40 UTC

[GitHub] [airflow] cherkavi commented on a change in pull request #17526: remove redundant commit

cherkavi commented on a change in pull request #17526:
URL: https://github.com/apache/airflow/pull/17526#discussion_r688712250



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -766,7 +766,17 @@ def _clean_tis_without_dagrun(self, session):
                 self._change_state_for_tis_without_dagrun(
                     old_states=[State.UP_FOR_RETRY], new_state=State.FAILED, session=session
                 )
-
+                
+                guard.commit()

Review comment:
       main idea here:
   1) protect "commit" operation
   2) split up code with two seprate actions, update status :
      2.1) mark as FAILED
      2.2) mark as None 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org