You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/10/26 22:53:24 UTC

Review Request 63341: Set `BUILD_FLAGS` flag in CMake.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63341/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, John Kordich, and Joseph Wu.


Bugs: MESOS-5455
    https://issues.apache.org/jira/browse/MESOS-5455


Repository: mesos


Description
-------

This resolves MESOS-5455, and consolidates the `BUILD` variables into
one location.


Diffs
-----

  cmake/CompilationConfigure.cmake 929e45bd810c99e036d433a8f0a0bc978c9841a2 
  src/CMakeLists.txt 219252f6f82b2d62d024b2ab876fa0ba2f5c8e6c 
  src/common/build_config.hpp.in ac7059ab2aa54011197b9e1a46f9d7fd39ac39c6 


Diff: https://reviews.apache.org/r/63341/diff/1/


Testing
-------

Checked the emitted `build_config.hpp` under various conditions; flags are set correctly (and can still build of course).


Thanks,

Andrew Schwartzmeyer