You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2016/02/03 02:56:18 UTC

[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

GitHub user liancheng opened a pull request:

    https://github.com/apache/spark/pull/11040

    [SPARK-13150] [SQL] [WIP] Adds extensive logs to investigate SPARK-13150

    **DON'T MERGE**
    
    This PR adds extensive logs to investigate two flaky test cases tracked by SPARK-13150.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/liancheng/spark spark-13150-wip

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/11040.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11040
    
----
commit 4d7db2e23a1875f3e55b8ee6280196d00598c844
Author: Cheng Lian <li...@databricks.com>
Date:   2016-02-03T01:55:06Z

    Adds extensive logs to investigate SPARK-13150

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178956629
  
    **[Test build #2500 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2500/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179031474
  
    Oh, maybe the `@` character is treated as the separator between user/password and host/port in a URL.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178965739
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179043273
  
    **[Test build #50651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50651/consoleFull)** for PR 11040 at commit [`e6ebe1c`](https://github.com/apache/spark/commit/e6ebe1c2dc5a114511b7e05dc539ead08463568a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179048502
  
    Filed SPARK-13157 to track the `@` character issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179053695
  
    **[Test build #50651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50651/consoleFull)** for PR 11040 at commit [`e6ebe1c`](https://github.com/apache/spark/commit/e6ebe1c2dc5a114511b7e05dc539ead08463568a).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179030178
  
    @liancheng This should be a bug, can we reproduce it locally (add @ to the path)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179062331
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178964109
  
    **[Test build #2506 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2506/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178957798
  
    **[Test build #2505 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2505/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng closed the pull request at:

    https://github.com/apache/spark/pull/11040


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178965742
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50632/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178961775
  
    **[Test build #2501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2501/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179044891
  
    The Thrift server and the `ADD JAR` command are both pretty tricky to get right, I think it would be better to enable these tests first?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179055300
  
    Ah, our Jenkins PR builder overrides `java.io.tmpdir` property and the created temporary directory is still under a parent directory like `SparkPullRequestBuilder@2`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178956437
  
    **[Test build #2502 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2502/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11040#discussion_r51668888
  
    --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ---
    @@ -786,6 +787,7 @@ abstract class HiveThriftServer2Test extends SparkFunSuite with BeforeAndAfterAl
           val builder = new ProcessBuilder(command: _*)
           val captureOutput = (line: String) => diagnosisBuffer.synchronized {
             diagnosisBuffer += line
    +        logInfo(line)
    --- End diff --
    
    This dumps Thrift server logs to `unit-tests.log`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178959277
  
    **[Test build #50632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50632/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178956638
  
    **[Test build #2503 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2503/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178965694
  
    **[Test build #50632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50632/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179031677
  
    The second line seems weird, where is the `@`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178962280
  
    **[Test build #2502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2502/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179030901
  
    My guess is that when a PR Jenkins build is triggered by the Spark PR dashboard and the build is scheduled to any builder other than the 1st builder, which doesn't include the `@n` suffix, this bug is triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178963659
  
    **[Test build #2504 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2504/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179045198
  
    Actually I've already pushed the fix to this PR branch...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179061969
  
    **[Test build #50652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50652/consoleFull)** for PR 11040 at commit [`b6b186f`](https://github.com/apache/spark/commit/b6b186f1597c7e8de94e8eaf9706b1e2fa226358).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179062334
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50652/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178962007
  
    **[Test build #2500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2500/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178957690
  
    Just scheduled a build wave, trying to reproduce the test failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179040143
  
    @liancheng Since these tests are ignored, we could wait for the fix (@), do need to rush a work around.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178964392
  
    **[Test build #2505 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2505/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178963027
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50631/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178956333
  
    **[Test build #2501 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2501/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178962013
  
    **[Test build #2503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2503/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179039604
  
    Complete log line snippet:
    
    ```
    16/02/02 18:38:00 INFO ParseDriver: Parsing command: ADD JAR file:///home/jenkins/workspace/SparkPullRequestBuilder@2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar
    16/02/02 18:38:00 INFO ParseDriver: Parse completed.
    16/02/02 18:38:00 DEBUG HiveClientImpl: Running hiveql 'ADD JAR file:///home/jenkins/workspace/SparkPullRequestBuilder2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar'
    16/02/02 18:38:00 DEBUG VariableSubstitution: Substitution is on: JAR file:///home/jenkins/workspace/SparkPullRequestBuilder2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar
    16/02/02 18:38:00 DEBUG Groups: Returning cached groups for 'jenkins'
    16/02/02 18:38:00 DEBUG Groups: Returning cached groups for 'jenkins'
    16/02/02 18:38:00 DEBUG SessionState: Session is using authorization class class org.apache.hadoop.hive.ql.security.authorization.DefaultHiveAuthorizationProvider
    16/02/02 18:38:00 ERROR SessionState: file:///home/jenkins/workspace/SparkPullRequestBuilder2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar does not exist
    ```
    
    Full log file can be downloaded [here][1] (`hive-thriftserver/target/unit-tests.log`).
    
    [1]: https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2506/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178957873
  
    **[Test build #2506 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2506/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179039783
  
    I'm going to fix this issue using the workaround mentioned above and file a separate JIRA ticket for the `@` character issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179038743
  
    @davies The `@` character is removed after being parsed by HiveQL parser (`ParserDriver`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178963023
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11040#discussion_r51668973
  
    --- Diff: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ---
    @@ -493,12 +493,12 @@ class HiveThriftBinaryServerSuite extends HiveThriftJdbcTest {
           val jarPath = "../hive/src/test/resources/TestUDTF.jar"
           val jarURL = s"file://${System.getProperty("user.dir")}/$jarPath"
     
    -      Seq(
    -        s"ADD JAR $jarURL",
    +      statement.execute(s"ADD JAR $jarURL")
    +      statement.execute(
             s"""CREATE TEMPORARY FUNCTION udtf_count2
                |AS 'org.apache.spark.sql.hive.execution.GenericUDTFCount2'
              """.stripMargin
    -      ).foreach(statement.execute)
    +      )
    --- End diff --
    
    When the original code fails, log lines only say that one of the commands within the `Seq` fails. I'd like to know which one fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178956436
  
    **[Test build #50631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50631/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178962716
  
    **[Test build #50631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50631/consoleFull)** for PR 11040 at commit [`4d7db2e`](https://github.com/apache/spark/commit/4d7db2e23a1875f3e55b8ee6280196d00598c844).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179053790
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/50651/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-178957809
  
    **[Test build #2504 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2504/consoleFull)** for PR 11040 at commit [`a3cdb43`](https://github.com/apache/spark/commit/a3cdb436310e720f20f5169ed6927684ffd1aea7).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179053786
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179028394
  
    Found 3 interesting log lines:
    
    ```
    16/02/02 18:38:00 INFO ParseDriver: Parsing command: ADD JAR file:///home/jenkins/workspace/SparkPullRequestBuilder@2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar
    ...
    16/02/02 18:38:00 DEBUG HiveClientImpl: Running hiveql 'ADD JAR file:///home/jenkins/workspace/SparkPullRequestBuilder2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar'
    ...
    16/02/02 18:38:00 ERROR SessionState: file:///home/jenkins/workspace/SparkPullRequestBuilder2/sql/hive-thriftserver/../hive/src/test/resources/TestUDTF.jar does not exist
    ```
    
    Please notice that the first log line has `SparkPullRequestBuilder@2` in the file path while the 2nd and 3rd ones have `SparkPullRequestBuilder2` Seems that the HiveQL parser somehow drops the `@` character, and then causes execution failure of the `ADD JAR` command.
    
    One possible workaround is to first copy the jar file to a temporary location whose path doesn't have any interesting characters and then execute `ADD JAR` using that path.
    
    cc @davies


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179052535
  
    **[Test build #50652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50652/consoleFull)** for PR 11040 at commit [`b6b186f`](https://github.com/apache/spark/commit/b6b186f1597c7e8de94e8eaf9706b1e2fa226358).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] [WIP] Adds extensive logs ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179030322
  
    Actually the `ADD JAR` command doesn't fail, but the jar wasn't successfully added, and the following `CREATE TEMPORARY FUNCTION` command failed.
    
    Verified this behavior using the following Beeline session:
    
    ```
    > add jar file:///tmp/a@b/TestUDTF.jar;
    ...
    > CREATE TEMPORARY FUNCTION udtf_count2 AS 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
    Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
    ```
    
    The `TestUDTF.jar` is copied from Spark code repo.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-13150] [SQL] Fixes flaky Thrift server ...

Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:

    https://github.com/apache/spark/pull/11040#issuecomment-179074117
  
    Seems that the `@` removal bug is causing more serious build failures like [this one][1]. My theory is that some test case added a resource whose path containing `@` to `TestHive`. The `ADD` command itself succeeds but the resource isn't successfully added since the `@` character in the path is removed. This breaks internal state of `TestHive` and causes successive test failures.
    
    Thus I agree with @davies that we should have a proper fix of the `@` removal bug rather than adding a workaround. So closing this.
    
    [1]: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50650/testReport/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org