You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "hemantsoni42 (via GitHub)" <gi...@apache.org> on 2023/01/29 13:44:14 UTC
[GitHub] [netbeans] hemantsoni42 opened a new pull request, #5383: Fixed Unit test on single file is converted to integration test #4587
hemantsoni42 opened a new pull request, #5383:
URL: https://github.com/apache/netbeans/pull/5383
adding an extra check in extractFileObjectsFromLookup method to making sure the result will not empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5383: Fixed Unit test on single file is converted to integration test #4587
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5383:
URL: https://github.com/apache/netbeans/pull/5383#issuecomment-1407679178
This isn't the issue and fix discussed on #4587 either. Does this actually fix the issue? Because part of the report covers the fact that `extractFileObjectsFromLookup` isn't used in that path.
As far as I remember, it's `isIntegrationTestTarget` that needs fixing to get the values from `extractFileObjectsFromLookup`, and always return false if the result is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hemantsoni42 closed pull request #5383: Fixed Unit test on single file is converted to integration test #4587
Posted by "hemantsoni42 (via GitHub)" <gi...@apache.org>.
hemantsoni42 closed pull request #5383: Fixed Unit test on single file is converted to integration test #4587
URL: https://github.com/apache/netbeans/pull/5383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists