You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/05 00:12:33 UTC
Review Request 43225: Introduced gtest actions for subscribe,
sending updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433
Repository: mesos
Description
-------
This change adds some gtest actions that can be used to subscribe/send status updates using the executor library. These are in similar vein to the existing actions like `SendStatusUpdateFromTask`.
Diffs
-----
src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488
Diff: https://reviews.apache.org/r/43225/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43225: Introduced gtest actions for subscribe,
sending updates.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 8, 2016, 10:12 p.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, lines 964-1021
> > <https://reviews.apache.org/r/43225/diff/1/?file=1233180#file1233180line964>
> >
> > put these (using statement and actions) in v1 namespace?
Added a `TODO` as per our discussion to move these actions to the `v1` namespace and then do a sweep of the other test files.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/#review118304
-----------------------------------------------------------
On Feb. 9, 2016, 12:12 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43225/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 12:12 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds some gtest actions that can be used to subscribe/send status updates using the executor library. These are in similar vein to the existing actions like `SendStatusUpdateFromTask`.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8
>
> Diff: https://reviews.apache.org/r/43225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43225: Introduced gtest actions for subscribe,
sending updates.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/#review118304
-----------------------------------------------------------
src/tests/mesos.hpp (lines 964 - 1021)
<https://reviews.apache.org/r/43225/#comment179526>
put these (using statement and actions) in v1 namespace?
- Vinod Kone
On Feb. 4, 2016, 11:12 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43225/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 11:12 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds some gtest actions that can be used to subscribe/send status updates using the executor library. These are in similar vein to the existing actions like `SendStatusUpdateFromTask`.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488
>
> Diff: https://reviews.apache.org/r/43225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43225: Introduced gtest actions for subscribe,
sending updates.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/#review118341
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 9, 2016, 12:12 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43225/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 12:12 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4433
> https://issues.apache.org/jira/browse/MESOS-4433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds some gtest actions that can be used to subscribe/send status updates using the executor library. These are in similar vein to the existing actions like `SendStatusUpdateFromTask`.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8
>
> Diff: https://reviews.apache.org/r/43225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43225: Introduced gtest actions for subscribe,
sending updates.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43225/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 12:12 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comments from Vinod
Bugs: MESOS-4433
https://issues.apache.org/jira/browse/MESOS-4433
Repository: mesos
Description
-------
This change adds some gtest actions that can be used to subscribe/send status updates using the executor library. These are in similar vein to the existing actions like `SendStatusUpdateFromTask`.
Diffs (updated)
-----
src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8
Diff: https://reviews.apache.org/r/43225/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar