[GitHub] [lucene] dweiss commented on a diff in pull request #844: LUCENE-10539: Return a stream of completions from FSTCompletion.

[GitBox <gi...@apache.org>]

dweiss commented on code in PR #844:
URL: https://github.com/apache/lucene/pull/844#discussion_r859526919


##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/fst/TestFSTCompletion.java:
##########
@@ -130,8 +153,17 @@ public void testAlphabeticWithWeights() throws Exception {
   }
 
   public void testFullMatchList() throws Exception {
+    // one/0.0 is returned first because it's an exact match.

Review Comment:
   This seems to be a bug in the current Lucene implementation - one/0.0 is ordered last, even though exact match flag is true. I corrected the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org