You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/01/13 13:39:31 UTC
[GitHub] [tomcat] DoiMasayuki opened a new pull request #234:
PrepareStatement methods are extracted
DoiMasayuki opened a new pull request #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234
`prepareStatement()` methods are duplicated.
This PR extracts a private method from the `prepareStatement()` methods and simplifies codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] DoiMasayuki commented on issue #234: PrepareStatement
methods are extracted
Posted by GitBox <gi...@apache.org>.
DoiMasayuki commented on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574493644
OK. I requested to Commons DBCP just now.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] 72er-de edited a comment on issue #234: PrepareStatement
methods are extracted
Posted by GitBox <gi...@apache.org>.
72er-de edited a comment on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574242126
Looks good for me. The same could be done with method prepareCall()?
[PoolingConnection.java](https://github.com/apache/tomcat/files/4060224/PoolingConnection.java.txt)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] DoiMasayuki edited a comment on issue #234:
PrepareStatement methods are extracted
Posted by GitBox <gi...@apache.org>.
DoiMasayuki edited a comment on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574493644
OK. I requested this pull request to Commons DBCP just now.
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #234: PrepareStatement
methods are extracted
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] PascalSchumacher commented on issue #234: PrepareStatement
methods are extracted
Posted by GitBox <gi...@apache.org>.
PascalSchumacher commented on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574359819
If I am not mistaken these classes are a fork of https://github.com/apache/commons-dbcp and are synched from time to time.
Therefore it would be better to create a pull request for https://github.com/apache/commons-dbcp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #234: PrepareStatement
methods are extracted
Posted by GitBox <gi...@apache.org>.
markt-asf commented on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574362029
Correct. Patches should go to Commons DBCP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] PascalSchumacher edited a comment on issue #234:
PrepareStatement methods are extracted
Posted by GitBox <gi...@apache.org>.
PascalSchumacher edited a comment on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574359819
If I am not mistaken these classes are a fork of https://github.com/apache/commons-dbcp and are synced from time to time.
Therefore it would be better to create a pull request for https://github.com/apache/commons-dbcp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] 72er-de commented on issue #234: PrepareStatement methods
are extracted
Posted by GitBox <gi...@apache.org>.
72er-de commented on issue #234: PrepareStatement methods are extracted
URL: https://github.com/apache/tomcat/pull/234#issuecomment-574242126
Looks good for me. The same could be done with method prepareCall()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org