You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/11/03 18:42:47 UTC

[GitHub] [groovy] eric-milles opened a new pull request #1063: GROOVY-8507, GROOVY-9301: support comma on last enum value in more cases

eric-milles opened a new pull request #1063: GROOVY-8507, GROOVY-9301: support comma on last enum value in more cases
URL: https://github.com/apache/groovy/pull/1063
 
 
   and reduce ambiguity within (antlr2) enumConstants loop.
   
   **Note**: This does not address the antlr4 parser. GROOVY-8507 was listed as resolved for Parrot Parser.  GROOVY-9301 is untested -- be sure to include tests for trailing comma followed by nested class, interface, trait and @interface; annotated and unannotated constructor; annotated and unannotated field; annotated and unannotated property; object initializer; static initializer.
   
   There was an edit made after last change for GROOVY-4438 that appears to support "enum E {\n A,\n B,\n ;\n}" with no test case.  Is there a desire to have trailing comma followed by semicolon?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services