You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/04 15:37:54 UTC

[GitHub] [incubator-nuttx] davids5 commented on pull request #1506: Allow single wire mode to use push pull to support inverted protocols (S.Port etc)

davids5 commented on pull request #1506:
URL: https://github.com/apache/incubator-nuttx/pull/1506#issuecomment-668670003


   @patacongo, @xiaoxiang781216 @acassis , @Ouss4  The majority of the style failures are long lines. I will do a pass to fix them, but I have a question.
   
   There are some well formatted tables in the code
   
   ![image](https://user-images.githubusercontent.com/1945821/89313199-0bea5380-d62d-11ea-9c09-1fdaa01e3ec4.png)
   
    and one liner logic statements that will become less readable.
   
   ![image](https://user-images.githubusercontent.com/1945821/89313396-4a800e00-d62d-11ea-9936-3bb36bd6b51b.png)
   
   I have lost context on the current thinking.  Is the option for make the comment rulers  longer allowable to preserve the readability or should I just remove information from the tables wrap the lines at 78?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org