You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/04/10 08:15:31 UTC
[PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
raulcd opened a new pull request, #41120:
URL: https://github.com/apache/arrow/pull/41120
### Rationale for this change
Windows wheels are currently failing due to the change on `ARCHERY_DEBUG=1` by default.
### What changes are included in this PR?
Do not use `ARCHERY_DEBUG=1` on the Windows builds.
### Are these changes tested?
Yes on CI via archery.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2048733496
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 06f0e0c7088b571a2265e116893a03cda0a919ab.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23687275809) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2047389364
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2047176455
@kou are you ok with this? This is needed for 16.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2047299749
Or can we remove --progress on Windows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2048411688
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #41120:
URL: https://github.com/apache/arrow/pull/41120#discussion_r1559301652
##########
.env:
##########
@@ -98,7 +98,7 @@ VCPKG="a42af01b72c28a8e1d7b48107b33e4f286a55ef6" # 2023.11.20 Release
# ci/docker/python-wheel-windows-vs2019.dockerfile.
# This is a workaround for our CI problem that "archery docker build" doesn't
# use pulled built images in dev/tasks/python-wheels/github.windows.yml.
-PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=2024-03-19
+PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=2024-04-10
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2048415591
Revision: f6580cd53b0de0016cc57211c80278da9aa69027
Submitted crossbow builds: [ursacomputing/crossbow @ actions-17855e7166](https://github.com/ursacomputing/crossbow/branches/all?query=actions-17855e7166)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8637649582/job/23680319116)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8637649581/job/23680319104)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8637649583/job/23680319229)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8637649585/job/23680319065)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8637649588/job/23680319074)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using --progress flag on Docker on Windows on archery [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #41120:
URL: https://github.com/apache/arrow/pull/41120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2046862731
:warning: GitHub issue #41119 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #41120:
URL: https://github.com/apache/arrow/pull/41120#discussion_r1559228850
##########
.env:
##########
@@ -98,7 +98,7 @@ VCPKG="a42af01b72c28a8e1d7b48107b33e4f286a55ef6" # 2023.11.20 Release
# ci/docker/python-wheel-windows-vs2019.dockerfile.
# This is a workaround for our CI problem that "archery docker build" doesn't
# use pulled built images in dev/tasks/python-wheels/github.windows.yml.
-PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=2024-03-19
+PYTHON_WHEEL_WINDOWS_IMAGE_REVISION=2024-04-10
Review Comment:
Can we revert this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2046863610
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2046872700
Revision: 82d4ade778475e41b2e16ba962b636732a0a9f32
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d7303f0760](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d7303f0760)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8628124435/job/23649516180)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8628124377/job/23649516074)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8628124455/job/23649516186)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8628124425/job/23649516096)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8628124475/job/23649516598)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2047393629
Revision: af01e7b358a7226a690294e6d6851123d53ce2f5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-28a241eefe](https://github.com/ursacomputing/crossbow/branches/all?query=actions-28a241eefe)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8631057836/job/23658669829)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8631057776/job/23658669617)|
|wheel-windows-cp312-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8631057741/job/23658669310)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8631057654/job/23658669271)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8631057646/job/23658669291)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41119: [Archery][Packaging][CI] Avoid using ARCHERY_DEBUG=1 on Windows wheels as --progress flag is not supported on Docker on Windows [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #41120:
URL: https://github.com/apache/arrow/pull/41120#issuecomment-2047569567
> Or can we remove --progress on Windows?
@kou I've updated the PR to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org