You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhangstar333 (via GitHub)" <gi...@apache.org> on 2024/01/04 09:59:39 UTC
[PR] [refactor](fold) refactor fold executor could get error status [doris]
zhangstar333 opened a new pull request, #29541:
URL: https://github.com/apache/doris/pull/29541
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 merged PR #29541:
URL: https://github.com/apache/doris/pull/29541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1876845667
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877151961
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit d0668ab67f2479282f3c6baa30d57b273cdf4714, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5451 5192 5120 5120
q2 395 164 158 158
q3 1468 1195 1184 1184
q4 1076 780 767 767
q5 3110 3194 3091 3091
q6 226 137 138 137
q7 964 584 545 545
q8 2163 2223 2221 2221
q9 6714 6638 6684 6638
q10 3181 3112 3129 3112
q11 333 227 209 209
q12 379 240 238 238
q13 4418 3653 3613 3613
q14 248 227 214 214
q15 585 542 543 542
q16 452 400 404 400
q17 1053 457 467 457
q18 7093 6866 6775 6775
q19 1646 1496 1400 1400
q20 604 329 359 329
q21 2960 2484 2540 2484
q22 398 344 329 329
Total cold run time: 44917 ms
Total hot run time: 39963 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 5110 5046 5092 5046
q2 341 235 238 235
q3 3379 3332 3314 3314
q4 2156 2055 2053 2053
q5 5985 5946 5944 5944
q6 228 127 133 127
q7 2391 1909 1940 1909
q8 3573 3695 3690 3690
q9 9029 9011 8994 8994
q10 3863 3904 3906 3904
q11 583 496 474 474
q12 804 640 651 640
q13 3898 3201 3184 3184
q14 293 262 267 262
q15 592 541 536 536
q16 561 511 512 511
q17 2032 1821 1841 1821
q18 8787 8368 8368 8368
q19 1755 1686 1730 1686
q20 2270 2001 1967 1967
q21 5798 5360 5376 5360
q22 565 528 508 508
Total cold run time: 63993 ms
Total hot run time: 60533 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877147540
TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools
```
TPC-DS sf100 test result on commit d0668ab67f2479282f3c6baa30d57b273cdf4714, data reload: false
run tpcds-sf100 query with default conf and session variables
query1 866 348 341 341
query2 4024 1913 2023 1913
query3 4963 212 209 209
query4 26410 22487 22437 22437
query5 3136 561 571 561
query6 262 178 179 178
query7 4044 262 260 260
query8 223 201 193 193
query9 6951 2593 2562 2562
query10 417 240 232 232
query11 16294 15527 15568 15527
query12 127 75 76 75
query13 1353 323 315 315
query14 9814 7089 7110 7089
query15 218 186 189 186
query16 5143 266 264 264
query17 1288 490 483 483
query18 1600 268 261 261
query19 173 143 139 139
query20 85 75 76 75
query21 182 102 93 93
query22 5102 4885 4594 4594
query23 32297 31261 31401 31261
query24 12245 2870 2854 2854
query25 619 348 331 331
query26 1722 145 140 140
query27 2847 274 273 273
query28 6767 1885 1881 1881
query29 2334 399 390 390
query30 285 144 142 142
query31 1000 762 766 762
query32 87 58 53 53
query33 707 263 265 263
query34 981 446 433 433
query35 882 740 761 740
query36 1340 1189 1296 1189
query37 165 66 71 66
query38 3400 3301 3259 3259
query39 1325 1308 1288 1288
query40 288 90 86 86
query41 38 35 36 35
query42 94 83 81 81
query43 547 485 499 485
query44 1045 701 698 698
query45 195 199 187 187
query46 1075 666 645 645
query47 1648 1506 1545 1506
query48 325 265 255 255
query49 1178 324 320 320
query50 746 331 368 331
query51 5379 5239 5258 5239
query52 96 85 85 85
query53 213 148 148 148
query54 2052 565 575 565
query55 92 88 85 85
query56 204 187 175 175
query57 1045 934 950 934
query58 213 200 199 199
query59 2900 2660 2666 2660
query60 232 212 205 205
query61 87 85 86 85
query62 637 477 461 461
query63 163 153 146 146
query64 5334 1724 1699 1699
query65 3339 3250 3259 3250
query66 1444 334 335 334
query67 15771 15633 15718 15633
query68 11696 491 519 491
query69 484 248 256 248
query70 1919 1564 1509 1509
query71 398 207 215 207
query72 5570 3591 3599 3591
query73 2918 310 307 307
query74 7018 6488 6526 6488
query75 5373 2300 2279 2279
query76 5852 1125 1134 1125
query77 666 258 244 244
query78 9188 8617 8594 8594
query79 1466 492 496 492
query80 539 358 342 342
query81 462 208 208 208
query82 204 95 89 89
query83 161 149 136 136
query84 239 54 50 50
query85 919 267 271 267
query86 383 386 421 386
query87 3545 3398 3404 3398
query88 2977 2251 2253 2251
query89 345 271 254 254
query90 1901 191 188 188
query91 123 89 94 89
query92 67 52 50 50
query93 1561 482 487 482
query94 761 172 172 172
query95 449 399 407 399
query96 622 315 314 314
query97 4282 4153 4159 4153
query98 207 191 189 189
query99 1104 843 810 810
Total cold run time: 281457 ms
Total hot run time: 179646 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877150899
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.75 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.3 seconds inserted 10000000 Rows, about 353K ops/s
storage size: 17183787029 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877131206
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools
```
Tpch sf100 test result on commit d0668ab67f2479282f3c6baa30d57b273cdf4714, data reload: false
------ Round 1 ----------------------------------
q1 18033 5100 5076 5076
q2 2011 157 148 148
q3 10612 1056 1116 1056
q4 10196 764 810 764
q5 7806 2981 2927 2927
q6 210 133 132 132
q7 931 512 521 512
q8 9283 2017 2000 2000
q9 6831 6434 6454 6434
q10 8313 3007 3054 3007
q11 427 218 220 218
q12 396 232 230 230
q13 18003 3614 3634 3614
q14 243 206 211 206
q15 560 527 510 510
q16 515 413 398 398
q17 980 528 464 464
q18 7343 6789 6737 6737
q19 1598 1315 1350 1315
q20 692 346 331 331
q21 2814 2334 2446 2334
q22 378 318 308 308
Total cold run time: 108175 ms
Total hot run time: 38721 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5134 5103 5093 5093
q2 340 232 236 232
q3 3303 3291 3285 3285
q4 2130 2022 2013 2013
q5 5835 5789 5803 5789
q6 213 122 124 122
q7 2346 1918 1910 1910
q8 3377 3457 3448 3448
q9 8795 8800 8744 8744
q10 3786 3837 3822 3822
q11 588 470 476 470
q12 800 633 664 633
q13 9228 3209 3171 3171
q14 302 269 273 269
q15 580 530 516 516
q16 577 490 511 490
q17 1980 1740 1765 1740
q18 8702 8444 8334 8334
q19 1628 1570 1582 1570
q20 2205 1945 1939 1939
q21 5585 5228 5229 5228
q22 553 482 495 482
Total cold run time: 67987 ms
Total hot run time: 59300 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #29541:
URL: https://github.com/apache/doris/pull/29541#discussion_r1441561905
##########
be/src/runtime/fold_constant_executor.cpp:
##########
@@ -158,96 +158,125 @@ Status FoldConstantExecutor::_prepare_and_open(Context* ctx) {
return ctx->open(_runtime_state.get());
}
-string FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
+Status FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
Review Comment:
warning: method '_get_result' can be made static [readability-convert-member-functions-to-static]
```suggestion
static Status FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
```
##########
be/src/runtime/fold_constant_executor.cpp:
##########
@@ -158,96 +158,125 @@
return ctx->open(_runtime_state.get());
}
-string FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
+Status FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
Review Comment:
warning: function '_get_result' exceeds recommended size/complexity thresholds [readability-function-size]
```cpp
Status FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
^
```
<details>
<summary>Additional context</summary>
**be/src/runtime/fold_constant_executor.cpp:160:** 116 lines including whitespace and comments (threshold 80)
```cpp
Status FoldConstantExecutor::_get_result(void* src, size_t size, const TypeDescriptor& type,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "zhangstar333 (via GitHub)" <gi...@apache.org>.
zhangstar333 commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877100485
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1877135549
TeamCity be ut coverage result:
Function Coverage: 36.64% (8616/23518)
Line Coverage: 28.67% (70021/244207)
Region Coverage: 27.65% (36238/131074)
Branch Coverage: 24.34% (18507/76044)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d0668ab67f2479282f3c6baa30d57b273cdf4714_d0668ab67f2479282f3c6baa30d57b273cdf4714/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fold) refactor fold executor could get error status [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29541:
URL: https://github.com/apache/doris/pull/29541#issuecomment-1876845720
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org