[GitHub] [superset] zamar-roura commented on a diff in pull request #21325: feat(db_engine_specs): big query cost estimation

[GitBox <gi...@apache.org>]

zamar-roura commented on code in PR #21325:
URL: https://github.com/apache/superset/pull/21325#discussion_r1045262511


##########
superset/config.py:
##########
@@ -873,7 +873,8 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 # query costs before they run. These EXPLAIN queries should have a small
 # timeout.
 SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT = int(timedelta(seconds=10).total_seconds())
-# The feature is off by default, and currently only supported in Presto and Postgres.
+# The feature is off by default, and currently only supported in Presto and Postgres,
+# and Bigquery.

Review Comment:
   Fixed the things and added some more comments.
   
   About the docs I would love to fix the content. Only thing is that the superset/blob/master/docs/sqllab.rst file doesnt even exist now. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org