You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/11 05:48:20 UTC
[GitHub] [spark] wangyum commented on a diff in pull request #37140: [SPARK-39726][SQL] Change the default value of spark.sql.execution.topKSortFallbackThreshold to 800000
wangyum commented on code in PR #37140:
URL: https://github.com/apache/spark/pull/37140#discussion_r917561201
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3029,7 +3029,10 @@ object SQLConf {
" in memory, otherwise do a global sort which spills to disk if necessary.")
.version("2.4.0")
.intConf
- .createWithDefault(ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH)
+ .checkValue(_ <= ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH,
+ "The top-K sort fallback threshold should be less than or equal to " +
+ s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}.")
+ .createWithDefault(800000)
Review Comment:
Will close this PR because it has a regression.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3029,7 +3029,10 @@ object SQLConf {
" in memory, otherwise do a global sort which spills to disk if necessary.")
.version("2.4.0")
.intConf
- .createWithDefault(ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH)
+ .checkValue(_ <= ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH,
+ "The top-K sort fallback threshold should be less than or equal to " +
+ s"${ByteArrayMethods.MAX_ROUNDED_ARRAY_LENGTH}.")
+ .createWithDefault(800000)
Review Comment:
Will close this PR because it has a regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org