You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "aokolnychyi (via GitHub)" <gi...@apache.org> on 2026/03/02 19:59:10 UTC

Re: [PR] [SPARK-55695][SQL] Avoid double planning in row-level operations [spark]

aokolnychyi commented on code in PR #54492:
URL: https://github.com/apache/spark/pull/54492#discussion_r2874401585


##########
sql/core/src/test/scala/org/apache/spark/sql/connector/RowLevelOperationSuiteBase.scala:
##########
@@ -206,7 +223,7 @@ abstract class RowLevelOperationSuiteBase
       case Seq(partValue) => partValue
       case other => fail(s"expected only one partition value: $other" )
     }
-    assert(actualPartitions == expectedPartitions, "replaced partitions must match")
+    assert(actualPartitions.toSet == expectedPartitions.toSet, "replaced partitions must match")

Review Comment:
   Making the check more robust and order-independent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org