You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sg...@apache.org on 2014/07/02 11:28:49 UTC
git commit: fixes potential perf issue inside exec_verbose method
Repository: cordova-windows
Updated Branches:
refs/heads/master b3a9d0824 -> 1215a84fd
fixes potential perf issue inside exec_verbose method
see CB-7060 WP8. Fix large project build performance issue
Project: http://git-wip-us.apache.org/repos/asf/cordova-windows/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-windows/commit/1215a84f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-windows/tree/1215a84f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-windows/diff/1215a84f
Branch: refs/heads/master
Commit: 1215a84fd80c1a17f0fe6376c3894397fefe46a7
Parents: b3a9d08
Author: sgrebnov <v-...@microsoft.com>
Authored: Wed Jul 2 13:28:43 2014 +0400
Committer: sgrebnov <v-...@microsoft.com>
Committed: Wed Jul 2 13:28:43 2014 +0400
----------------------------------------------------------------------
windows/template/cordova/lib/build.js | 2 +-
windows/template/cordova/lib/deploy.js | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/1215a84f/windows/template/cordova/lib/build.js
----------------------------------------------------------------------
diff --git a/windows/template/cordova/lib/build.js b/windows/template/cordova/lib/build.js
index 4549d3e..77879a6 100644
--- a/windows/template/cordova/lib/build.js
+++ b/windows/template/cordova/lib/build.js
@@ -66,7 +66,7 @@ function exec_verbose(command) {
//Wait a little bit so we're not super looping
WScript.sleep(100);
//Print any stdout output from the script
- if (!oShell.StdOut.AtEndOfStream) {
+ while (!oShell.StdOut.AtEndOfStream) {
var line = oShell.StdOut.ReadLine();
Log(line);
}
http://git-wip-us.apache.org/repos/asf/cordova-windows/blob/1215a84f/windows/template/cordova/lib/deploy.js
----------------------------------------------------------------------
diff --git a/windows/template/cordova/lib/deploy.js b/windows/template/cordova/lib/deploy.js
index e99bd2d..0bc9f1b 100644
--- a/windows/template/cordova/lib/deploy.js
+++ b/windows/template/cordova/lib/deploy.js
@@ -105,8 +105,8 @@ function exec_verbose(command) {
//Wait a little bit so we're not super looping
WScript.sleep(100);
//Print any stdout output from the script
- if (!oShell.StdOut.AtEndOfStream) {
- line = oShell.StdOut.ReadAll();
+ while (!oShell.StdOut.AtEndOfStream) {
+ line = oShell.StdOut.ReadLine();
Log(line);
}
}