You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/26 13:07:32 UTC
[GitHub] [ozone] adoroszlai opened a new pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
adoroszlai opened a new pull request #3019:
URL: https://github.com/apache/ozone/pull/3019
## What changes were proposed in this pull request?
Selective CI checks has a test suite, but currently it needs to be run manually. This PR adds it to the _bats_ check in CI.
The test verifies the list of selective checks triggered for some known commits. Thus we need to checkout the repo with full history for the _bats_ check.
https://issues.apache.org/jira/browse/HDDS-6226
## How was this patch tested?
Verified that _bats_ check includes the test for selective checks script:
```
1..16
ok 1 checkstyle and bats
ok 2 compose only
ok 3 compose and robot
ok 4 check script
ok 5 integration only
ok 6 kubernetes only
ok 7 docs only
ok 8 java-only change
ok 9 java and compose change
ok 10 java and docs change
ok 11 pom change
ok 12 CI lib change
ok 13 CI workflow change
ok 14 root README
ok 15 ignored code
ok 16 other README
```
https://github.com/adoroszlai/hadoop-ozone/runs/4951581169#step:5:14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3019:
URL: https://github.com/apache/ozone/pull/3019#issuecomment-1022393188
@GeorgeJahad this is another improvement for selective checks in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3019:
URL: https://github.com/apache/ozone/pull/3019#issuecomment-1033409030
Thank you @GeorgeJahad and @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GeorgeJahad commented on pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
GeorgeJahad commented on pull request #3019:
URL: https://github.com/apache/ozone/pull/3019#issuecomment-1023445833
+1 lgtm
This is a good addition. Just yesterday, while reviewing the other PR's I was wondering why this hadn't been done already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] GeorgeJahad commented on pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
GeorgeJahad commented on pull request #3019:
URL: https://github.com/apache/ozone/pull/3019#issuecomment-1022400247
@adoroszlai will take a look tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3019:
URL: https://github.com/apache/ozone/pull/3019#issuecomment-1033020441
@smengcl could you please review this small patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3019: HDDS-6226. Run tests for selective CI checks in CI
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #3019:
URL: https://github.com/apache/ozone/pull/3019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org