You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/19 12:43:22 UTC
[GitHub] [flink] zentol opened a new pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
zentol opened a new pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140
Add a baseline of dependencies that we allow to be unused, along with a set of dependencies that we allowed to be used without a declared dependencies.
The purpose here is to ease the analysis of unused dependencies by excluding non-critical dependencies.
You can compare the difference by running `mvn dependency:analyze` before and after this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11140: [FLINK-16172][build]
Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-588209749
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7d7126525a80f03746bdee2b96b7341fbb55c6f1 (Wed Feb 19 12:47:40 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#discussion_r381904774
##########
File path: pom.xml
##########
@@ -1676,6 +1676,44 @@ under the License.
<version>1.11.1</version>
</dependency>
</dependencies>
+ <configuration>
+ <ignoredUsedUndeclaredDependencies combine.children="append">
+ <!-- allow using transitive Flink dependencies for brevity -->
+ <dependency>org.apache.flink:*</dependency>
Review comment:
not sure, but I would advice against it anyway since unused test dependencies are also problematic form a maintenance perspective as the still restrict the dependency graph (in case of Flink dependencies) and can introduce dependency conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11140: [FLINK-16172][build]
Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-594555549
Looks good to me, +1 to go ahead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on a change in pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#discussion_r381906573
##########
File path: pom.xml
##########
@@ -1676,6 +1676,44 @@ under the License.
<version>1.11.1</version>
</dependency>
</dependencies>
+ <configuration>
+ <ignoredUsedUndeclaredDependencies combine.children="append">
+ <!-- allow using transitive Flink dependencies for brevity -->
+ <dependency>org.apache.flink:*</dependency>
Review comment:
fair enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-588228486
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7d7126525a80f03746bdee2b96b7341fbb55c6f1",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149633775",
"triggerID" : "7d7126525a80f03746bdee2b96b7341fbb55c6f1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d7126525a80f03746bdee2b96b7341fbb55c6f1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149633775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#discussion_r381904774
##########
File path: pom.xml
##########
@@ -1676,6 +1676,44 @@ under the License.
<version>1.11.1</version>
</dependency>
</dependencies>
+ <configuration>
+ <ignoredUsedUndeclaredDependencies combine.children="append">
+ <!-- allow using transitive Flink dependencies for brevity -->
+ <dependency>org.apache.flink:*</dependency>
Review comment:
not sure, but I would advice against it anyway since unused test dependencies are also problematic form a maintenance perspective as the still restrict the dependency graph (in case of Flink dependencies) and may introduce dependency conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11140: [FLINK-16172][build] Add
baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-594539234
@StephanEwen What's your overall take on the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11140: [FLINK-16172][build]
Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-588228486
<!--
Meta data
Hash:7d7126525a80f03746bdee2b96b7341fbb55c6f1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7d7126525a80f03746bdee2b96b7341fbb55c6f1
-->
## CI report:
* 7d7126525a80f03746bdee2b96b7341fbb55c6f1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on a change in pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#discussion_r381860125
##########
File path: pom.xml
##########
@@ -1676,6 +1676,44 @@ under the License.
<version>1.11.1</version>
</dependency>
</dependencies>
+ <configuration>
+ <ignoredUsedUndeclaredDependencies combine.children="append">
+ <!-- allow using transitive Flink dependencies for brevity -->
+ <dependency>org.apache.flink:*</dependency>
Review comment:
Is there a shortcut to ignore dependencies in `test` scope?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-588228486
<!--
Meta data
Hash:7d7126525a80f03746bdee2b96b7341fbb55c6f1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149633775 TriggerType:PUSH TriggerID:7d7126525a80f03746bdee2b96b7341fbb55c6f1
-->
## CI report:
* 7d7126525a80f03746bdee2b96b7341fbb55c6f1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149633775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11140: [FLINK-16172][build] Add
baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#issuecomment-588228486
<!--
Meta data
Hash:7d7126525a80f03746bdee2b96b7341fbb55c6f1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149633775 TriggerType:PUSH TriggerID:7d7126525a80f03746bdee2b96b7341fbb55c6f1
-->
## CI report:
* 7d7126525a80f03746bdee2b96b7341fbb55c6f1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149633775)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services