You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/03/06 16:37:24 UTC

[GitHub] [nifi] mattyb149 commented on a change in pull request #3354: NIFI-6106 Add tests for commons utilities & fix FormatUtils bug

mattyb149 commented on a change in pull request #3354: NIFI-6106 Add tests for commons utilities & fix FormatUtils bug
URL: https://github.com/apache/nifi/pull/3354#discussion_r263028178
 
 

 ##########
 File path: nifi-commons/nifi-properties/src/test/java/org/apache/nifi/util/StringUtilsTest.java
 ##########
 @@ -0,0 +1,81 @@
+package org.apache.nifi.util;
+
+import static org.junit.Assert.*;
 
 Review comment:
   Looks good, thanks for the fix and additional tests! This line is a CheckStyle violation though, need to replace the star import with individual ones, please and thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services