You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2015/03/16 17:10:04 UTC
Review Request 32110: SQOOP-2202 Sqoop2: Add validator to check
existence of local directory on Sqoop 2 server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32110/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2202
https://issues.apache.org/jira/browse/SQOOP-2202
Repository: sqoop-sqoop2
Description
-------
Added proposed validator.
Diffs
-----
common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/validators/TestDirectoryExistsValidator.java PRE-CREATION
Diff: https://reviews.apache.org/r/32110/diff/
Testing
-------
Newly added test is succeeding.
Thanks,
Jarek Cecho
Re: Review Request 32110: SQOOP-2202 Sqoop2: Add validator to check
existence of local directory on Sqoop 2 server
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32110/#review76593
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 16, 2015, 5:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32110/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2202
> https://issues.apache.org/jira/browse/SQOOP-2202
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added proposed validator.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/validators/TestDirectoryExistsValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32110/diff/
>
>
> Testing
> -------
>
> Newly added test is succeeding.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32110: SQOOP-2202 Sqoop2: Add validator to check
existence of local directory on Sqoop 2 server
Posted by Jarek Cecho <ja...@apache.org>.
> On March 16, 2015, 5:07 p.m., Abraham Elmahrek wrote:
> > Also, it's not being used. Assuming it will be used in a diff patch?
Yup, I'll need it on SQOOP-2201.
> On March 16, 2015, 5:07 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java, lines 31-33
> > <https://reviews.apache.org/r/32110/diff/2/?file=896007#file896007line31>
> >
> > Error?
Intentional behavior, this way you can make the corresponding input optional (no value is correct value). If you need to make it required, you'll simply chain NotEmpty && DirectoryExists.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32110/#review76575
-----------------------------------------------------------
On March 16, 2015, 5:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32110/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2202
> https://issues.apache.org/jira/browse/SQOOP-2202
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added proposed validator.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/validators/TestDirectoryExistsValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32110/diff/
>
>
> Testing
> -------
>
> Newly added test is succeeding.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32110: SQOOP-2202 Sqoop2: Add validator to check
existence of local directory on Sqoop 2 server
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32110/#review76575
-----------------------------------------------------------
Also, it's not being used. Assuming it will be used in a diff patch?
common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java
<https://reviews.apache.org/r/32110/#comment124154>
Error?
- Abraham Elmahrek
On March 16, 2015, 5:03 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32110/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:03 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2202
> https://issues.apache.org/jira/browse/SQOOP-2202
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Added proposed validator.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java PRE-CREATION
> common/src/test/java/org/apache/sqoop/validation/validators/TestDirectoryExistsValidator.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32110/diff/
>
>
> Testing
> -------
>
> Newly added test is succeeding.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 32110: SQOOP-2202 Sqoop2: Add validator to check
existence of local directory on Sqoop 2 server
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32110/
-----------------------------------------------------------
(Updated March 16, 2015, 5:03 p.m.)
Review request for Sqoop.
Changes
-------
Add protection for empty/null input.
Bugs: SQOOP-2202
https://issues.apache.org/jira/browse/SQOOP-2202
Repository: sqoop-sqoop2
Description
-------
Added proposed validator.
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/validation/validators/DirectoryExistsValidator.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/validators/TestDirectoryExistsValidator.java PRE-CREATION
Diff: https://reviews.apache.org/r/32110/diff/
Testing
-------
Newly added test is succeeding.
Thanks,
Jarek Cecho