Re: Review Request 12138: Add accessors for the sender-settle-mode and receiver-settle-mode

[Gordon Sim <gs...@redhat.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12138/#review22727
-----------------------------------------------------------



/proton/trunk/proton-c/include/proton/engine.h
<https://reviews.apache.org/r/12138/#comment46421>

    'comma at end of enumerator list' error when used from qpid/cpp


- Gordon Sim


On June 27, 2013, 8:09 p.m., Kenneth Giusti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12138/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 8:09 p.m.)
> 
> 
> Review request for qpid, Gordon Sim, Rob Godfrey, and Rafael Schloming.
> 
> 
> Bugs: proton-81
>     https://issues.apache.org/jira/browse/proton-81
> 
> 
> Repository: qpid
> 
> 
> Description
> -------
> 
> Provide an API to access the sender-settle-mode and receiver-settle-mode of the Link.
> 
> Added a test to verify the settings are "negotiated" properly on link attach.
> 
> Modified Messenger to override the defaults when windowing is used (explicit settlement needed).
> 
> 
> Diffs
> -----
> 
>   /proton/trunk/proton-c/bindings/python/proton.py 1497342 
>   /proton/trunk/proton-c/include/proton/engine.h 1497342 
>   /proton/trunk/proton-c/src/engine/engine-internal.h 1497342 
>   /proton/trunk/proton-c/src/engine/engine.c 1497342 
>   /proton/trunk/proton-c/src/messenger/messenger.c 1497342 
>   /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1497342 
>   /proton/trunk/tests/python/proton_tests/engine.py 1497342 
> 
> Diff: https://reviews.apache.org/r/12138/diff/
> 
> 
> Testing
> -------
> 
> ctest
> 
> 
> Thanks,
> 
> Kenneth Giusti
> 
>