[PR] fix(dropdown): position [myfaces-tobago]

["henningn (via GitHub)" <gi...@apache.org>]

henningn opened a new pull request, #7639:
URL: https://github.com/apache/myfaces-tobago/pull/7639

   fix: Sometimes the dropdown menu opens to the left or tries to use the whole page width, even if there is enough space on the right side.
   
   It was actually two bugs.
   First: To determine if the content of a dropdown fits in the given size, the max-width inline style was compared with offsetWidth. The issue: max-width can be a float value, for example 120.5px. But offsetWidth is a rounded integer value. Instead of 120.5px, offsetWidth has the value 121px.
   
   Second bug affects only Firefox (current version is 155.0.1). To determine if the content of a dropdown fits in the given size, there must be no horizonal scrollbar. But if the .tobago-dropdown-menu class has a max-height set via CSS class and the content has a min-width set, there might be a scrollbar in firefox while calculating the dropdown position. Sadly I could not implement an automated test for this. So there is only a manual test.
   
   * add tests
   * fix both previously described issues
   
   Issue: TOBAGO-2541


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(dropdown): position [myfaces-tobago]

["henningn (via GitHub)" <gi...@apache.org>]

henningn merged PR #7639:
URL: https://github.com/apache/myfaces-tobago/pull/7639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org