You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/29 01:28:00 UTC
[jira] [Commented] (ZOOKEEPER-2825) 1. Remove unncessnary import;
2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize
`StringBuilder#append` usage for CLI module
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16067558#comment-16067558 ]
ASF GitHub Bot commented on ZOOKEEPER-2825:
-------------------------------------------
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/297
ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLI module
* Remove unnecessary import;
* `contains` instead of `indexOf > -1` for more readable;
* Standardize `StringBuilder#append` usage for CLI module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2825
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
commit 91ef299ae58dc22b5954a24a6f2ecba1b7b7c3f2
Author: asdf2014 <15...@qq.com>
Date: 2017-06-29T01:25:23Z
1. Remove unncessnary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLI module
----
> 1. Remove unncessnary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLI module
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2825
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2825
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.5.3
> Reporter: Benedict Jin
> Assignee: Benedict Jin
> Fix For: 3.5.4, 3.6.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> * Remove unncessnary import;
> * `contains` instead of `indexOf > -1` for more readable;
> * Standardize `StringBuilder#append` usage for CLI module
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)