[GitHub] mistercrunch commented on issue #4920: form_data always returns empty dict

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #4920: form_data always returns empty dict
URL: https://github.com/apache/incubator-superset/issues/4920#issuecomment-387296640
 
 
   `query_obj`  is hashed to define the caching key. If we'd pass the `form_data` in there, changing any control that does not affect the query (say `show_legend` for example) wouldn't hit the cache even though the query is the same. 
   
   By providing `form_data` to the template, users can in theory use it to change the query template, meaning since we don't know in what way they may be doing this, or even which key in form_data they're using we really have to cache based on everything in `form_data`.
   
   While we could allow this an still cache based on the hash disregarding `form_data` it may be intricately confusing to users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org