GSOC-Branch - ready to merge into trunk?

["P. Ottlinger" <po...@aiki-it.de>]

Hi guys,

Robert merged the GSOC stuff into a separate branch - in case there are
no objections I'd start to merge the branch back to trunk.

Since all tests hopefully run on the branch I assume no functionality
broken, but will check carefully upon merge/commit.

Any objections?

Thanks,
Phil

PS:
http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/
or
https://github.com/elnuma/creadur-rat/tree/gsoc

Re: GSOC-Branch - ready to merge into trunk?

["P. Ottlinger" <po...@aiki-it.de>]

Hi,

Am 02.08.2014 um 19:38 schrieb Dennis Lundberg:
> We should really release Rat 0.11 before we merge the branch into trunk. It
> has been on my todo list fora while, but I have some time in the coming
> week, and will try to push a release out.

Alright - sounds like a plan.

I'd just want to augment the project's poms to include Jira and Jenkins
links after I've fixed this broken build. Strangely I do not see these
problems locally ....

Cheers,
Phil

Re: GSOC-Branch - ready to merge into trunk?

[Dennis Lundberg <de...@apache.org>]

Hi Phil,

We should really release Rat 0.11 before we merge the branch into trunk. It
has been on my todo list fora while, but I have some time in the coming
week, and will try to push a release out.

--
Dennis Lundberg
Den 31 jul 2014 22:18 skrev "P. Ottlinger" <po...@aiki-it.de>:

> Hi guys,
>
> Robert merged the GSOC stuff into a separate branch - in case there are
> no objections I'd start to merge the branch back to trunk.
>
> Since all tests hopefully run on the branch I assume no functionality
> broken, but will check carefully upon merge/commit.
>
> Any objections?
>
> Thanks,
> Phil
>
> PS:
> http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/
> or
> https://github.com/elnuma/creadur-rat/tree/gsoc
>

Re: GSOC-Branch - ready to merge into trunk? - RAT-195

["P. Ottlinger" <po...@apache.org>]

Fellow devs,

I've created RAT-195 as a task to perform commits on.

Am 31.07.2014 um 22:18 schrieb P. Ottlinger:
> Since all tests hopefully run on the branch I assume no functionality
> broken, but will check carefully upon merge/commit.

OVERVIEW
I browsed the rather old branch and do not really see a lot of use in
autogenerated Javadoc comments such as

/**
* Returns the foo for parameter a
*/
private Foo getFoo(Parameter a) {
....
}

In such cases I'd rather have no Javadoc - any objections to merging in
this way (and leaving out these mass automatically generated not really
helpful Javadoc)?


MERGING/COMMIT-strategy
Would you mind me merging in these changes piece by piece instead of one
big bang commit?

It does not seem to me that a lot of development is going on at the
moment, thus a stepwise commit seems fine to me.

Cheers,
Phil