You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by el...@apache.org on 2026/07/14 10:22:31 UTC
(superset) branch fix/a11y-tagmodal-description-label created (now 3d60765b15e)
This is an automated email from the ASF dual-hosted git repository.
eschutho pushed a change to branch fix/a11y-tagmodal-description-label
in repository https://gitbox.apache.org/repos/asf/superset.git
at 3d60765b15e fix(a11y): use more specific label text for tag description field
This branch includes the following new commits:
new 221d44dac4f fix(a11y): associate Description label with TagModal input
new 3d60765b15e fix(a11y): use more specific label text for tag description field
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 02/02: fix(a11y): use more specific label text for tag description field
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
eschutho pushed a commit to branch fix/a11y-tagmodal-description-label
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 3d60765b15e9615efd5a8c6017d4dd078894c606
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Tue Jul 14 10:18:22 2026 +0000
fix(a11y): use more specific label text for tag description field
Self-review suggested "Tag description" for parity with the sibling
"Tag name" field, since a generic "Description" label is more
ambiguous outside the dialog's visual context (e.g. in a flattened
screen-reader forms list).
---
superset-frontend/src/features/tags/TagModal.test.tsx | 2 +-
superset-frontend/src/features/tags/TagModal.tsx | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/features/tags/TagModal.test.tsx b/superset-frontend/src/features/tags/TagModal.test.tsx
index c9235e001e9..ee38ff43ecb 100644
--- a/superset-frontend/src/features/tags/TagModal.test.tsx
+++ b/superset-frontend/src/features/tags/TagModal.test.tsx
@@ -47,7 +47,7 @@ test('renders correctly in create mode', () => {
test('description input has an accessible name', async () => {
render(<TagModal {...mockedProps} />);
- expect(await screen.findByLabelText('Description')).toBeInTheDocument();
+ expect(await screen.findByLabelText('Tag description')).toBeInTheDocument();
});
test('renders correctly in edit mode', () => {
diff --git a/superset-frontend/src/features/tags/TagModal.tsx b/superset-frontend/src/features/tags/TagModal.tsx
index bdb1bfca8f6..1d80276d453 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -312,7 +312,9 @@ const TagModal: FC<TagModalProps> = ({
</Flex>
<Flex vertical gap={theme.sizeUnit}>
- <FormLabel htmlFor="tag-description">{t('Description')}</FormLabel>
+ <FormLabel htmlFor="tag-description">
+ {t('Tag description')}
+ </FormLabel>
<Input
id="tag-description"
className="tag-input"
(superset) 01/02: fix(a11y): associate Description label with TagModal input
Posted by el...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
eschutho pushed a commit to branch fix/a11y-tagmodal-description-label
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 221d44dac4fe9ddf972219c1fa58d503712b867d
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Tue Jul 14 10:15:07 2026 +0000
fix(a11y): associate Description label with TagModal input
WCAG 2.1 SC 4.1.2 — Level A.
The Tag name field already wires FormLabel/Input via htmlFor+id, but
the Description field below it was missing both, leaving the visible
label programmatically unassociated with its input.
---
superset-frontend/src/features/tags/TagModal.test.tsx | 5 +++++
superset-frontend/src/features/tags/TagModal.tsx | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/features/tags/TagModal.test.tsx b/superset-frontend/src/features/tags/TagModal.test.tsx
index 0fce2de2e83..c9235e001e9 100644
--- a/superset-frontend/src/features/tags/TagModal.test.tsx
+++ b/superset-frontend/src/features/tags/TagModal.test.tsx
@@ -45,6 +45,11 @@ test('renders correctly in create mode', () => {
expect(getByText('Create Tag')).toBeInTheDocument();
});
+test('description input has an accessible name', async () => {
+ render(<TagModal {...mockedProps} />);
+ expect(await screen.findByLabelText('Description')).toBeInTheDocument();
+});
+
test('renders correctly in edit mode', () => {
fetchMock.get(fetchEditFetchObjects, [[]]);
const editTag: Tag = {
diff --git a/superset-frontend/src/features/tags/TagModal.tsx b/superset-frontend/src/features/tags/TagModal.tsx
index aea360617de..bdb1bfca8f6 100644
--- a/superset-frontend/src/features/tags/TagModal.tsx
+++ b/superset-frontend/src/features/tags/TagModal.tsx
@@ -312,8 +312,9 @@ const TagModal: FC<TagModalProps> = ({
</Flex>
<Flex vertical gap={theme.sizeUnit}>
- <FormLabel>{t('Description')}</FormLabel>
+ <FormLabel htmlFor="tag-description">{t('Description')}</FormLabel>
<Input
+ id="tag-description"
className="tag-input"
onChange={handleDescriptionChange}
placeholder={t('Add description of your tag')}