You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:05:36 UTC

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/
-----------------------------------------------------------

(Updated Aug. 10, 2015, 7:05 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Summary (updated)
-----------------

Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
  include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 

Diff: https://reviews.apache.org/r/37178/diff/


Testing
-------


Thanks,

Joris Van Remoortere

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

Posted by Guangya Liu <gy...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review96265
-----------------------------------------------------------



include/mesos/scheduler/scheduler.proto (line 70)
<https://reviews.apache.org/r/37178/#comment151604>

    I think that the comments also needs to be updated to reflect inverse offer.



include/mesos/v1/scheduler/scheduler.proto (line 70)
<https://reviews.apache.org/r/37178/#comment151605>

    ditto


- Guangya Liu


On 八月 18, 2015, 7:02 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37178/
> -----------------------------------------------------------
> 
> (Updated 八月 18, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 
> 
> Diff: https://reviews.apache.org/r/37178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

Posted by Guangya Liu <gy...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review96281
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37178/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto 89daf8a6b74057ee156b3ad691397e76fcb835b8 
>   include/mesos/v1/scheduler/scheduler.proto bd5e82a614b1163b29f9b20e562208efa1ba4b55 
> 
> Diff: https://reviews.apache.org/r/37178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>