You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/11 00:34:14 UTC

[GitHub] [pulsar-client-python] tisonkun opened a new pull request, #38: [improve][ci] check python doc syntax

tisonkun opened a new pull request, #38:
URL: https://github.com/apache/pulsar-client-python/pull/38

   After #28 we have an apidoc generator with raw content. Thus we'd better check the doc string syntax for every PR so that we don't introduce trivial regressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-python] tisonkun commented on a diff in pull request #38: [improve][ci] check python doc syntax

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #38:
URL: https://github.com/apache/pulsar-client-python/pull/38#discussion_r1019823876


##########
.asf.yaml:
##########
@@ -28,43 +28,23 @@ github:
     - queuing
     - event-streaming
   features:
-    # Enable wiki for documentation
-    wiki: true
-    # Enable issues management
+    wiki: false
     issues: true
-    # Enable projects for project management boards
     projects: true
   enabled_merge_buttons:
-    # enable squash button:
     squash:  true
-    # disable merge button:
     merge:   false
-    # disable rebase button:
     rebase:  false
   protected_branches:
     main:
       required_status_checks:
-      #   # strict means "Require branches to be up to date before merging".
-        strict: false
-      #   # Contexts are the names of checks that must pass.
-      #   # See ./github/workflows/README.md for more documentation on this list.
+        # Contexts are the names of checks that must pass.
+        # See ./github/workflows/README.md for more documentation on this list.
         contexts:
            - Check Completion
-
       required_pull_request_reviews:
-        dismiss_stale_reviews: false
-        require_code_owner_reviews: true
         required_approving_review_count: 1
 
-      # squash or rebase must be allowed in the repo for this setting to be set to true.
-      required_linear_history: true
-
-      required_signatures: false

Review Comment:
   Omit default settings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar-client-python] merlimat merged pull request #38: [improve][ci] check python doc syntax

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #38:
URL: https://github.com/apache/pulsar-client-python/pull/38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org