[GitHub] [ozone] ChenSammi commented on a change in pull request #2009: HDDS-4916. No ACL check when uploading object through multi-upload.

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #2009:
URL: https://github.com/apache/ozone/pull/2009#discussion_r594898870



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
##########
@@ -126,7 +128,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
       multipartKey = omMetadataManager.getMultipartKey(volumeName,
           bucketName, keyName, uploadID);
 
-      // TODO to support S3 ACL later.
+      // check Acl
+      checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
+          IAccessAuthorizer.ACLType.WRITE, OzoneObj.ResourceType.KEY);

Review comment:
       Xiaoyu, from user's point of view,  to upload a object, both CREATE and WRITE permission are needed.  Currently OmKeyCreateRequest checks CREATE permission and OmKeyCommitRequest checks WRITE permission.  Multi-upload follows the same rule,  CREATE permission is checked when initiating a multi-upload request. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org