You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/22 20:58:59 UTC

svn commit: r1775736 - /jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java

Author: pmouawad
Date: Thu Dec 22 20:58:59 2016
New Revision: 1775736

URL: http://svn.apache.org/viewvc?rev=1775736&view=rev
Log:
Sonar : Fix errors and code smells

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java?rev=1775736&r1=1775735&r2=1775736&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/core/AbstractSampleWriter.java Thu Dec 22 20:58:59 2016
@@ -44,7 +44,7 @@ import org.apache.jorphan.util.JOrphanUt
  * 
  * @since 3.0
  */
-abstract public class AbstractSampleWriter extends SampleWriter {
+public abstract class AbstractSampleWriter extends SampleWriter {
 
     private static final int BUF_SIZE = 10000;
 
@@ -65,7 +65,7 @@ abstract public class AbstractSampleWrit
      *            sample writer
      */
     public void setWriter(Writer newWriter) {
-        Validate.notNull(newWriter, "writer must not be null.");
+        Validate.notNull(newWriter, "writer must not be null."); // NOSONAR
 
         if (this.writer != null) {
             // flush and close previous writer
@@ -120,12 +120,11 @@ abstract public class AbstractSampleWrit
         this.writer = null;
     }
 
-    public void flush() {
-        try {
-            writer.flush();
-        } catch (Exception e) {
-            // ignore
-        }
+    /**
+     * flush writer.
+     * Only used for Tests
+     */
+    void flush() {
+        writer.flush();
     }
-
 }