You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/25 03:45:34 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
AngersZhuuuu opened a new pull request, #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456
### What changes were proposed in this pull request?
Two `ShuffleClient.get()` implement is same logic, remove unnecessary one.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456#issuecomment-1521138658
ping @RexXiong @pan3793 , please take a look if this will affect k8s environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456#issuecomment-1534284543
Any more suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456#issuecomment-1521122433
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1456?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1456](https://codecov.io/gh/apache/incubator-celeborn/pull/1456?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6174c1f) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/537fc94df298b22479159e50579228491a4b7353?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (537fc94) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
+ Coverage 44.82% 44.97% +0.15%
==========================================
Files 155 155
Lines 9586 9586
Branches 955 955
==========================================
+ Hits 4296 4310 +14
+ Misses 5007 4995 -12
+ Partials 283 281 -2
```
[see 1 file with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1456/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1456: [CELEBORN-551] Remove unnecessary ShuffleClient.get()
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1456:
URL: https://github.com/apache/incubator-celeborn/pull/1456#issuecomment-1534367901
This should be fine since both of them share the `lifecycleHost` under the hood.
```
return new RssShuffleHandle<>(
newAppId,
lifecycleManager.getRssMetaServiceHost(),
lifecycleManager.getRssMetaServicePort(),
lifecycleManager.getUserIdentifier(),
shuffleId,
dependency.rdd().getNumPartitions(),
dependency);
```
```
def getRssMetaServiceHost: String = {
lifecycleHost
}
```
```
override val rpcEnv: RpcEnv = RpcEnv.create(
RpcNameConstants.RSS_METASERVICE_SYS,
lifecycleHost,
conf.shuffleManagerPort,
conf)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org