You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2019/04/15 19:07:01 UTC

[GitHub] [incubator-daffodil] bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc

bsloane1650 commented on a change in pull request #207: Added support for enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r275503421
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/AnnotatedSchemaComponent.scala
 ##########
 @@ -38,7 +38,7 @@ import org.apache.daffodil.api.WarnID
  * property resolution.
  *
  * The only objects that should resolve properties are
- * ElementRef, Root, LocalElementDecl, Sequence, Choice, SequenceRef, ChoiceRef
+ * ElementRef, Root, LocalElementDecl, Sequence, Choice, SequenceRef, ChoiceRef, Enumeration
 
 Review comment:
   Will fix in the next commit. The above comment is already out of date anyway. The oddball objects are now EnumerationFactory and SimpleTypeDefFactory (for essentially the same reason that Enumeration was originally)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services