You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/08 03:02:22 UTC
[GitHub] [doris] SaintBacchus opened a new pull request, #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
SaintBacchus opened a new pull request, #13147:
URL: https://github.com/apache/doris/pull/13147
# Proposed changes
Issue Number: #13146
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r999028922
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1792,4 +1792,19 @@ public class Config extends ConfigBase {
@ConfField(mutable = false)
public static int statistic_task_scheduler_execution_interval_ms = 60 * 1000;
+
+ /*
+ * mtmv scheduler framework is still under dev, remote this config when it is graduate.
+ */
+ @ConfField(mutable = true)
+ public static boolean enable_mtmv_scheduler_framework = false;
+
+ @ConfField(mutable = true, masterOnly = true)
+ public static int running_mtmv_scheduler_task_size = 1000;
Review Comment:
```suggestion
public static int max_running_mtmv_scheduler_task_num = 100;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r1005145530
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2091,6 +2100,12 @@ private void createOlapTable(Database db, CreateTableStmt stmt) throws UserExcep
throw e;
}
+
+ // TODO: impl the real logic of create multi-table MaterializedView here.
+ if (olapTable instanceof MaterializedView && Config.enable_mtmv_scheduler_framework) {
+ Env.getCurrentEnv().getMtmvJobManager().createJob(MTMVJobFactory.buildJob((MaterializedView) olapTable),
Review Comment:
`getMtmvJobManager` -> `getMTMVJobManager`
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -884,6 +890,36 @@ public static void loadJournal(Env env, JournalEntity journal) {
env.getLoadManager().replayCleanLabel(log);
break;
}
+ case OperationType.OP_CREATE_MTMV_JOB: {
+ final MTMVJob job = (MTMVJob) journal.getData();
+ env.getMtmvJobManager().replayCreateJob(job);
Review Comment:
`getMtmvJobManager` -> `getMTMVJobManager`
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/metadata/MTMVTask.java:
##########
@@ -0,0 +1,187 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.mtmv.metadata;
+
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.mtmv.MTMVUtils;
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+
+public class MTMVTask implements Writable {
+ // also named query id in ConnectContext
+ @SerializedName("taskId")
+ private String taskId;
+
+ @SerializedName("jobName")
+ private String jobName;
+
+ @SerializedName("createTime")
+ private long createTime;
+
+ @SerializedName("finishTime")
+ private long finishTime;
+
+ @SerializedName("state")
+ private MTMVUtils.TaskState state = MTMVUtils.TaskState.PENDING;
+
+ @SerializedName("dbName")
+ private String dbName;
+
+ @SerializedName("definition")
+ private String definition;
+
+ @SerializedName("user")
+ private String user;
+
+ @SerializedName("errorCode")
+ private int errorCode;
+
+ @SerializedName("errorMessage")
+ private String errorMessage;
+
+ @SerializedName("expireTime")
+ private long expireTime;
+
+ // the larger the value, the higher the priority, the default value is 0
+ @SerializedName("priority")
+ private int priority = 0;
+
+ @SerializedName("retryTimes")
+ private int retryTimes = 0;
+
+ public String getTaskId() {
+ return taskId;
+ }
+
+ public void setTaskId(String taskId) {
+ this.taskId = taskId;
+ }
+
+ public String getJobName() {
+ return jobName;
+ }
+
+ public void setJobName(String jobName) {
+ this.jobName = jobName;
+ }
+
+ public long getCreateTime() {
+ return createTime;
+ }
+
+ public void setCreateTime(long createTime) {
+ this.createTime = createTime;
+ }
+
+ public long getFinishTime() {
+ return finishTime;
+ }
+
+ public void setFinishTime(long finishTime) {
+ this.finishTime = finishTime;
+ }
+
+ public MTMVUtils.TaskState getState() {
+ return state;
+ }
+
+ public void setState(MTMVUtils.TaskState state) {
+ this.state = state;
+ }
+
+ public String getDbName() {
+ return dbName;
+ }
+
+ public void setDbName(String dbName) {
+ this.dbName = dbName;
+ }
+
+ public String getUser() {
+ return user;
+ }
+
+ public void setUser(String user) {
+ this.user = user;
+ }
+
+ public String getDefinition() {
Review Comment:
`getDefinition` -> `getQuery`
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVJobFactory.java:
##########
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.mtmv;
+
+import org.apache.doris.catalog.MaterializedView;
+import org.apache.doris.mtmv.MTMVUtils.TriggerMode;
+import org.apache.doris.mtmv.metadata.MTMVJob;
+import org.apache.doris.mtmv.metadata.MTMVJob.JobSchedule;
+
+import java.util.concurrent.TimeUnit;
+
+public class MTMVJobFactory {
+ public static MTMVJob buildJob(MaterializedView materializedView) {
+ MTMVJob job = new MTMVJob(materializedView.getName());
+ JobSchedule jobSchedule = new JobSchedule(System.currentTimeMillis() / 1000, 1, TimeUnit.MINUTES);
+ job.setSchedule(jobSchedule);
+ job.setTriggerMode(TriggerMode.PERIODICAL);
+ job.setDbName("fake");
+ job.setDefinition("select * from fake");
Review Comment:
`setDefinition` -> `setQuery`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13147:
URL: https://github.com/apache/doris/pull/13147#issuecomment-1291836722
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13147:
URL: https://github.com/apache/doris/pull/13147#issuecomment-1286447008
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.87 seconds
load time: 567 seconds
storage size: 17154699298 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221021123300_clickbench_pr_32323.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r1002863740
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -1936,6 +1946,17 @@ public long loadCatalog(DataInputStream in, long checksum) throws IOException {
return checksum;
}
+ /**
+ * Load schedule jobs.
+ **/
+ public long loadJobManager(DataInputStream in, long checksum) throws IOException {
+ if (Config.enable_mtmv_scheduler_framework) {
+ this.mtmvJobManager = MtmvJobManager.read(in, checksum);
+ }
+ LOG.info("finished replay job and tasks from image");
Review Comment:
Move to the branch `if (Config.enable_mtmv_scheduler_framework)`
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -2209,6 +2230,13 @@ public long saveCatalog(CountingDataOutputStream out, long checksum) throws IOEx
return checksum;
}
+ public long saveJobManager(CountingDataOutputStream out, long checksum) throws IOException {
+ if (Config.enable_mtmv_scheduler_framework) {
+ Env.getCurrentEnv().getMtmvJobManager().write(out, checksum);
Review Comment:
Add a log as `loadMtmvJobManager`
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -432,6 +433,8 @@ public class Env {
private PolicyMgr policyMgr;
+ private MtmvJobManager mtmvJobManager;
Review Comment:
`MTMV` is short for *Multiple Table Materialized Table*. I think to use `MTMV` (all capital characters) is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r1002922895
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -432,6 +433,8 @@ public class Env {
private PolicyMgr policyMgr;
+ private MtmvJobManager mtmvJobManager;
Review Comment:
`MTMV` is short for *Multiple Table Materialized Table*. I think it is better to use `MTMV` (all capital characters).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r999029287
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1792,4 +1792,19 @@ public class Config extends ConfigBase {
@ConfField(mutable = false)
public static int statistic_task_scheduler_execution_interval_ms = 60 * 1000;
+
+ /*
+ * mtmv scheduler framework is still under dev, remote this config when it is graduate.
+ */
+ @ConfField(mutable = true)
+ public static boolean enable_mtmv_scheduler_framework = false;
+
+ @ConfField(mutable = true, masterOnly = true)
+ public static int running_mtmv_scheduler_task_size = 1000;
+
+ @ConfField(mutable = true, masterOnly = true)
+ public static int pending_mtmv_scheduler_task_size = 1000;
Review Comment:
```suggestion
public static int max_pending_mtmv_scheduler_task_num = 100;
```
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/metadata/ChangeMtmvTask.java:
##########
@@ -0,0 +1,133 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.mtmv.metadata;
+
+import org.apache.doris.common.io.Text;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.mtmv.MtmvUtils.TaskState;
+import org.apache.doris.persist.gson.GsonUtils;
+
+import com.google.gson.annotations.SerializedName;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+
+public class ChangeMtmvTask implements Writable {
Review Comment:
```suggestion
public class AlterMtmvTask implements Writable {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r999028922
##########
fe/fe-core/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -1792,4 +1792,19 @@ public class Config extends ConfigBase {
@ConfField(mutable = false)
public static int statistic_task_scheduler_execution_interval_ms = 60 * 1000;
+
+ /*
+ * mtmv scheduler framework is still under dev, remote this config when it is graduate.
+ */
+ @ConfField(mutable = true)
+ public static boolean enable_mtmv_scheduler_framework = false;
+
+ @ConfField(mutable = true, masterOnly = true)
+ public static int running_mtmv_scheduler_task_size = 1000;
Review Comment:
```suggestion
public static int max_running_mtmv_scheduler_task_num = 1000;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13147:
URL: https://github.com/apache/doris/pull/13147#discussion_r1002953537
##########
fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java:
##########
@@ -884,6 +890,36 @@ public static void loadJournal(Env env, JournalEntity journal) {
env.getLoadManager().replayCleanLabel(log);
break;
}
+ case OperationType.OP_CREATE_MTMV_JOB: {
+ final MtmvJob job = (MtmvJob) journal.getData();
+ env.getMtmvJobManager().replayCreateJob(job);
+ break;
+ }
+ case OperationType.OP_ALTER_MTMV_JOB: {
+ ChangeMvmtJob changeJob = (ChangeMvmtJob) journal.getData();
+ env.getMtmvJobManager().replayUpdateJob(changeJob);
+ break;
+ }
+ case OperationType.OP_DROP_MTMV_JOB: {
+ DropMtmvJob dropJob = (DropMtmvJob) journal.getData();
+ env.getMtmvJobManager().replayDropJobs(dropJob.getJobIds());
+ break;
+ }
+ case OperationType.OP_CREATE_MTMV_TASK: {
+ final MtmvTask task = (MtmvTask) journal.getData();
Review Comment:
Why are some objects marked as `final` objects and others are not?
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MtmvTaskExecutor.java:
##########
@@ -0,0 +1,179 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.mtmv;
+
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.common.Config;
+import org.apache.doris.mtmv.MtmvUtils.TaskState;
+import org.apache.doris.mtmv.metadata.MtmvJob;
+import org.apache.doris.mtmv.metadata.MtmvTask;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.QueryState;
+import org.apache.doris.thrift.TUniqueId;
+
+import com.google.common.collect.Maps;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.jetbrains.annotations.NotNull;
+
+import java.util.Map;
+import java.util.Objects;
+import java.util.UUID;
+import java.util.concurrent.Future;
+
+public class MtmvTaskExecutor implements Comparable<MtmvTaskExecutor> {
+ private static final Logger LOG = LogManager.getLogger(MtmvTaskExecutor.class);
+
+ private long jobId;
+
+ private Map<String, String> properties;
+
+ private Future<?> future;
+
+ private MtmvJob job;
+
+ private ConnectContext ctx;
+
+ private MtmvTaskProcessor processor;
+
+ private MtmvTask task;
+
+ public long getJobId() {
+ return jobId;
+ }
+
+ public void setJobId(long jobId) {
+ this.jobId = jobId;
+ }
+
+ public MtmvJob getJob() {
+ return job;
+ }
+
+ public void setJob(MtmvJob job) {
+ this.job = job;
+ }
+
+ public Map<String, String> getProperties() {
+ return properties;
+ }
+
+ public void setProperties(Map<String, String> properties) {
+ this.properties = properties;
+ }
+
+ public Future<?> getFuture() {
+ return future;
+ }
+
+ public void setFuture(Future<?> future) {
+ this.future = future;
+ }
+
+ public MtmvTaskProcessor getProcessor() {
+ return processor;
+ }
+
+ public void setProcessor(MtmvTaskProcessor processor) {
+ this.processor = processor;
+ }
+
+ public boolean executeTask() throws Exception {
+ MtmvTaskContext taskContext = new MtmvTaskContext();
+ taskContext.setDefinition(task.getDefinition());
Review Comment:
```suggestion
taskContext.setQuery(task.getQuery());
```
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MtmvTaskContext.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.mtmv;
+
+import org.apache.doris.qe.ConnectContext;
+
+import java.util.Map;
+
+public class MtmvTaskContext {
+ ConnectContext ctx;
+ String definition;
Review Comment:
```suggestion
String query;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #13147: [feature-wip][MTMV] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #13147:
URL: https://github.com/apache/doris/pull/13147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13147:
URL: https://github.com/apache/doris/pull/13147#issuecomment-1283975915
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 40.06 seconds
load time: 597 seconds
storage size: 17154768637 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221019205855_clickbench_pr_31435.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13147: [Enhancement][MultiTableMaterializedView] The schedule framework for the MTMV
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13147:
URL: https://github.com/apache/doris/pull/13147#issuecomment-1291836793
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org