You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@karaf.apache.org by "Jean-Baptiste Onofré (Jira)" <ji...@apache.org> on 2019/10/15 13:13:00 UTC

[jira] [Commented] (KARAF-6453) Registering a FeaturesListener re-loads all repositories

    [ https://issues.apache.org/jira/browse/KARAF-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951914#comment-16951914 ] 

Jean-Baptiste Onofré commented on KARAF-6453:
---------------------------------------------

Good catch !

> Registering a FeaturesListener re-loads all repositories
> --------------------------------------------------------
>
>                 Key: KARAF-6453
>                 URL: https://issues.apache.org/jira/browse/KARAF-6453
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 4.2.0
>            Reporter: Fabian Lange
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>              Labels: features
>             Fix For: 4.3.0, 4.2.8
>
>
> This is a regression from 4.2, just discovered.
> It was caused in 2017 by this commit:
> https://github.com/apache/karaf/commit/a75fabaf071b8274c7f266affa7ce7cdd87a2a22
> https://github.com/apache/karaf/commit/a75fabaf071b8274c7f266affa7ce7cdd87a2a22#diff-29d341aa18575466b113be9168a6e7adR264
> Here  the new RepositoryCacheImpl is used to create the repository. But despite its name, it does not use something from the cache, but it creates a new Repository.
> This now will always "load" the repository, potentially refreshing it over http.
> https://github.com/apache/karaf/commit/a75fabaf071b8274c7f266affa7ce7cdd87a2a22#diff-a3bb3d36b86e3a4c291627077972097aR47
> previously it only returned a Repository that was unloaded.
> Registering many FeaturesListeners wastes a lot of CPU.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)