You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by kalyan kumar kalvagadda <kk...@cloudera.com> on 2016/12/16 00:23:43 UTC
Review Request 54798: SENTRY-1546 Generic Policy provides bad error
messages for Sentry exceptions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
Repository: sentry
Description
-------
Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
I saw issue with exceptions created while role create/drop and made required changes.
Diffs
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798d
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632d
Diff: https://reviews.apache.org/r/54798/diff/
Testing
-------
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review161952
-----------------------------------------------------------
I would consider unifying error messages from SentryNoSuchObjectException and SentryAlreadyExistsException using their constructors rather then relying on consumers to produce uniiform error messages.
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 236)
<https://reviews.apache.org/r/54798/#comment233222>
Do we ened to construct the msg with your changes? The exception will have the message.
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 238)
<https://reviews.apache.org/r/54798/#comment233223>
Should we do something similar for SentryNoSuchObjectException?
- Alexander Kolbasov
On Jan. 17, 2017, 7:34 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54798/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2017, 7:34 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
> I saw issue with exceptions created while role create/drop and made required changes.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java b7ae63430cddb81cb3235a7b04ecf95410d8604f
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632ddef6ac5eec7b0e240c596f57f427fda9d
>
> Diff: https://reviews.apache.org/r/54798/diff/
>
>
> Testing
> -------
>
> I have performed tests using Sentrytool Client.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review167624
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Feb. 28, 2017, 5:57 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54798/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 5:57 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Bugs: SENTRY-1548
> https://issues.apache.org/jira/browse/SENTRY-1548
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
> I saw issue with exceptions created while role create/drop and made required changes.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388
>
>
> Diff: https://reviews.apache.org/r/54798/diff/4/
>
>
> Testing
> -------
>
> I have performed tests using Sentrytool Client.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 5:57 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments
Bugs: SENTRY-1548
https://issues.apache.org/jira/browse/SENTRY-1548
Repository: sentry
Description
-------
Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
I saw issue with exceptions created while role create/drop and made required changes.
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388
Diff: https://reviews.apache.org/r/54798/diff/
Testing
-------
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 2:20 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
Bugs: SENTRY-1548
https://issues.apache.org/jira/browse/SENTRY-1548
Repository: sentry
Description
-------
Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
I saw issue with exceptions created while role create/drop and made required changes.
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388
Diff: https://reviews.apache.org/r/54798/diff/
Testing
-------
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review167016
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2558)
<https://reviews.apache.org/r/54798/#comment239121>
Missing space between Role and roleName
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2567)
<https://reviews.apache.org/r/54798/#comment239122>
Extra "+" - it was in the original for no reason
- Alexander Kolbasov
On Feb. 27, 2017, 11:59 p.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54798/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 11:59 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
> I saw issue with exceptions created while role create/drop and made required changes.
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11
> sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388
>
> Diff: https://reviews.apache.org/r/54798/diff/
>
>
> Testing
> -------
>
> I have performed tests using Sentrytool Client.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/
-----------------------------------------------------------
(Updated Feb. 27, 2017, 11:59 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments.
Repository: sentry
Description
-------
Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
I saw issue with exceptions created while role create/drop and made required changes.
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryAlreadyExistsException.java f29c42f
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/exception/SentryNoSuchObjectException.java 70719e4
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 27dbfca
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7b926a5
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java b10c2f2
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java 3881c11
sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java 9b986d7
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 0239388
Diff: https://reviews.apache.org/r/54798/diff/
Testing
-------
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/
-----------------------------------------------------------
(Updated Jan. 17, 2017, 7:34 p.m.)
Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
Changes
-------
Addressed review comments
Repository: sentry
Description
-------
Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
I saw issue with exceptions created while role create/drop and made required changes.
Diffs (updated)
-----
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java b7ae63430cddb81cb3235a7b04ecf95410d8604f
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632ddef6ac5eec7b0e240c596f57f427fda9d
Diff: https://reviews.apache.org/r/54798/diff/
Testing
-------
I have performed tests using Sentrytool Client.
Thanks,
kalyan kumar kalvagadda
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by Mat Crocker <ma...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review160921
-----------------------------------------------------------
agreed with Vamsee, it needs a trimmedNamed + "_Already Exists" space before all messages
- Mat Crocker
On Dec. 16, 2016, 12:23 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54798/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2016, 12:23 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
> I saw issue with exceptions created while role create/drop and made required changes.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798d
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632d
>
> Diff: https://reviews.apache.org/r/54798/diff/
>
>
> Testing
> -------
>
> I have performed tests using Sentrytool Client.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>
Re: Review Request 54798: SENTRY-1546 Generic Policy provides bad
error messages for Sentry exceptions
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54798/#review160611
-----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 273)
<https://reviews.apache.org/r/54798/#comment231742>
Please give a space delimeter after the trimmedRoleName otherwise the message could get a bit difficult to read.
And pls address the same concern at other places as well.
- Vamsee Yarlagadda
On Dec. 16, 2016, 12:23 a.m., kalyan kumar kalvagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54798/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2016, 12:23 a.m.)
>
>
> Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Added code changes to SentryStore to have proper message (where the exceptions are originated). If this is done we can avoid decorating them later.
> I saw issue with exceptions created while role create/drop and made required changes.
>
>
> Diffs
> -----
>
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 742798d
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 898632d
>
> Diff: https://reviews.apache.org/r/54798/diff/
>
>
> Testing
> -------
>
> I have performed tests using Sentrytool Client.
>
>
> Thanks,
>
> kalyan kumar kalvagadda
>
>