Re: [PR] [SPARK-52348] [WIP] [DRAFT] Add support for Spark Connect handlers for pipeline commands [spark]

["sryza (via GitHub)" <gi...@apache.org>]

sryza commented on code in PR #51057:
URL: https://github.com/apache/spark/pull/51057#discussion_r2118560789


##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -115,20 +116,21 @@ message PipelineCommand {
     // The graph to start.
     optional string dataflow_graph_id = 1;
   }
-}
 
-// Parses the SQL file and registers all datasets and flows.
-message DefineSqlGraphElements {
-  // The graph to attach this dataset to.
-  optional string dataflow_graph_id = 1;
+  // Parses the SQL file and registers all datasets and flows.
+  message DefineSqlGraphElements {

Review Comment:
   There's a PR for this: https://github.com/apache/spark/pull/51044



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org