[GitHub] [flink] JingsongLi commented on a change in pull request #10325: [FLINK-14512][table] Introduce listPartitionsByFilter to Catalog

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #10325: [FLINK-14512][table] Introduce listPartitionsByFilter to Catalog
URL: https://github.com/apache/flink/pull/10325#discussion_r353001041
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/PushPartitionIntoTableSourceScanRule.scala
 ##########
 @@ -112,10 +155,7 @@ class PushPartitionIntoTableSourceScanRule extends RelOptRule(
     }
 
     val statistic = tableSourceTable.getStatistic
-    val newStatistic = if (remainingPartitions.size() == allPartitions.size()) {
-      // Keep all Statistics if no predicates can be pushed down
-      statistic
-    } else if (statistic == FlinkStatistic.UNKNOWN) {
+    val newStatistic = if (statistic == FlinkStatistic.UNKNOWN) {
 
 Review comment:
   We don't know `allPartitions` now...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services