You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/04/30 19:45:15 UTC
[GitHub] zeppelin pull request #2304: [hotfix] Improve Session #2302 fix
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2304
[hotfix] Improve Session #2302 fix
### What is this PR for?
After the merge of #2302 breaks authentication.
### What type of PR is it?
[Hot Fix]
### Todos
* [x] - Fix selenium logout issue (flaky test)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin hotfix/ImproveSession
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2304
----
commit f993b59fa16fff0add8d4bdc4d7fdf97cea9f981
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-04-30T19:34:07Z
improve session
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2304: [hotfix] Improve Session #2302 fix
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2304
@Tagar please help review this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2304: [hotfix] Improve Session #2302 fix
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/2304
[hotfix] Improve Session #2302 fix
### What is this PR for?
After the merge of #2302 breaks authentication.
### What type of PR is it?
[Hot Fix]
### Todos
* [x] - Fix selenium logout issue (flaky test)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin hotfix/ImproveSession
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2304
----
commit f993b59fa16fff0add8d4bdc4d7fdf97cea9f981
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-04-30T19:34:07Z
improve session
commit 94ba9e77478a2022b43e359fae56316ae1e7b37f
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-04-30T20:41:47Z
check if modal window is present, and then close it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2304: [hotfix] Improve Session #2302 fix
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2304
Thank you for the validation @Tagar, will merge it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2304: [hotfix] Improve Session #2302 fix
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/2304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2304: [hotfix] Improve Session #2302 fix
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2304
Thanks for prompt response @prabhjyotsingh
I've retested with `currentUser.login(token)` moved down 2 lines - Zeppelin doesn't kick out
now after attempt to open a note.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2304: [hotfix] Improve Session #2302 fix
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---