[jira] Closed: (MPCHANGELOG-46) ViewCVS URL bug

[ji...@codehaus.org]

Message:

   The following issue has been closed.

   Resolver: dion gillard
       Date: Fri, 1 Oct 2004 4:14 AM

Applied
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPCHANGELOG-46

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPCHANGELOG-46
    Summary: ViewCVS URL bug
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-changelog-plugin
   Fix Fors:
             1.8
   Versions:
             1.7.1

   Assignee: dion gillard
   Reporter: Juha Komulainen

    Created: Thu, 30 Sep 2004 6:13 AM
    Updated: Fri, 1 Oct 2004 4:14 AM

Description:
Changelog plugin produces invalid URLs when used with ViewCVS. According to MPCHANGELOG-10 this has already been fixed, but still this didn't work for me.

I tried both http://host/cgi-bin/viewcvs.cgi/?root=repo and http://host/cgi-bin/viewcvs.cgi/?cvsroot=repo, but in both cases the repository path was just appended right after the URL, instead of being inserted just before query parameters, resulting invalid URL.

Fortunately the fix is simple. In changelog.jsl the line:

<j:when test="${!empty(repositoryUrl)} and  ${repositoryUrl.indexOf('?')>0}">

needs to be changed to:

<j:when test="${!empty(repositoryUrl) and repositoryUrl.indexOf('?')>0}">



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org