You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by stiga-huang <gi...@git.apache.org> on 2018/03/02 15:11:32 UTC

[GitHub] orc pull request #223: ORC-311: Fix null points when StripeFooter corrupts

GitHub user stiga-huang opened a pull request:

    https://github.com/apache/orc/pull/223

    ORC-311: Fix null points when StripeFooter corrupts

    The c++ codes do not check streams got from the StripeStreamsImpl::getStream. It may return null pointers for corrupt StripeFooter, which crash the c++ Reader finally.
    
    Test files are attached to the JIRA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stiga-huang/orc check-streams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 6c21d6ee280106eab8e055af775a581e9d8ee7dc
Author: stiga-huang <hu...@...>
Date:   2018-03-02T14:53:44Z

    Fix null points when StripeFooter corrupts

----


---

[GitHub] orc issue #223: ORC-311: [C++] Fix null pointers when StripeFooter corrupts

Posted by stiga-huang <gi...@git.apache.org>.

Github user stiga-huang commented on the issue:

    https://github.com/apache/orc/pull/223
  
    @omalley Sure, done.


---

[GitHub] orc issue #223: ORC-311: [C++] Fix null pointers when StripeFooter corrupts

Posted by stiga-huang <gi...@git.apache.org>.

Github user stiga-huang commented on the issue:

    https://github.com/apache/orc/pull/223
  
    Hi @omalley, @majetideepak,
    I rebase and update the PR to simply check streams in the constructors. 


---

[GitHub] orc issue #223: ORC-311: [C++] Fix null pointers when StripeFooter corrupts

Posted by omalley <gi...@git.apache.org>.

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/223
  
    Clearly this change is failing on clang. Can you fix it? Most of the Linux distros have a clang package to install.


---

[GitHub] orc pull request #223: ORC-311: [C++] Fix null pointers when StripeFooter co...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/orc/pull/223


---