[GitHub] [hive] pkumarsinha commented on a change in pull request #2101: HIVE-24909: Skip the repl events from getting logged in notification log

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #2101:
URL: https://github.com/apache/hive/pull/2101#discussion_r630392694



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -584,6 +600,7 @@ public void rollbackTxn() throws LockException {
           e);
     } finally {
       resetTxnInfo();
+      replPolicy = null;

Review comment:
       same here

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Context.java
##########
@@ -123,6 +123,8 @@
   // up when we are done.
   private final Set<Context> subContexts;
 
+  private String replPolicy = null;

Review comment:
       nit: default would be null only. 

##########
File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
##########
@@ -539,12 +550,13 @@ public void commitTxn() throws LockException {
     } finally {
       // do all new reset in resetTxnInfo method to make sure that same code is there for replCommitTxn flow.
       resetTxnInfo();
+      replPolicy = null;

Review comment:
       Why not to move this to resetTxnInfo(). All the clean up is anyway there




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org