You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/09/15 01:41:59 UTC

[GitHub] [submarine] pingsutw opened a new pull request #401: [WEB] Support running standalone script

pingsutw opened a new pull request #401:
URL: https://github.com/apache/submarine/pull/401


   ### What is this PR for?
   Support running any python script in a single node.
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-625
   
   ### How should this be tested?
   https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/727226256
   
   ### Screenshots (if appropriate)
   ![Screenshot from 2020-09-15 09-30-11](https://user-images.githubusercontent.com/37936015/93154945-88e21000-f737-11ea-8ce8-8a3def39a3b3.png)
   ![Screenshot from 2020-09-15 09-30-21](https://user-images.githubusercontent.com/37936015/93154948-8b446a00-f737-11ea-9210-00a3e034022d.png)
   ![Screenshot from 2020-09-15 09-30-28](https://user-images.githubusercontent.com/37936015/93154951-8c759700-f737-11ea-9b2f-18bdf788829f.png)
   ![Screenshot from 2020-09-15 09-30-38](https://user-images.githubusercontent.com/37936015/93154952-8da6c400-f737-11ea-9bbb-177b9fa9b4c3.png)
   ![Screenshot from 2020-09-15 09-30-52](https://user-images.githubusercontent.com/37936015/93154956-8ed7f100-f737-11ea-9e98-bd22bd064c71.png)
   
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jiwq commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
jiwq commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-696254742


   +1 Will commit if no more comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jiwq commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
jiwq commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-693751772


   > @xunliu @jiwq Thanks for the review.
   > After discuss in online meeting, I will revise the UI again.
   > Please don't merge this PR.
   
   👌, I think you could better convert it to draft until it can be merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #401:
URL: https://github.com/apache/submarine/pull/401


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #401:
URL: https://github.com/apache/submarine/pull/401


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-695972321


   Ready for review. Update includes
   - Decrease description input size
   - Increase command input size
   - Combine `meta` and `env` page to single page 
   - Add a dropdown window to select namespace and image
   - Add a preview page
   - Add advanced button, click advanced button if need to update `namespace` and `environment variable`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-695972321


   Ready for review. Update includes
   - Decrease description input size
   - Increase command input size
   - Combine `meta` and `env` page to single page 
   - Add a dropdown window to select namespace and image
   - Add a preview page
   - Add advanced button, click advanced button if need to update `namespace` and `environment variable`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] pingsutw commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-693147705


   @xunliu @jiwq Thanks for the review.
   After discuss in online meeting, I will revise the UI again. 
   Please don't merge this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] jiwq commented on pull request #401: SUBMARINE-625. [WEB] Support running standalone script

Posted by GitBox <gi...@apache.org>.
jiwq commented on pull request #401:
URL: https://github.com/apache/submarine/pull/401#issuecomment-696254742


   +1 Will commit if no more comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org