You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/07 05:04:51 UTC
[GitHub] [arrow] domoritz opened a new pull request #10673: ARROW-13277: [JS] Add declaration maps
domoritz opened a new pull request #10673:
URL: https://github.com/apache/arrow/pull/10673
With declaration maps, developers can jump to the implementation rather than a declaration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10673: ARROW-13277: [JS] Add declaration maps
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#issuecomment-875282567
https://issues.apache.org/jira/browse/ARROW-13277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure
Posted by GitBox <gi...@apache.org>.
domoritz closed pull request #10673:
URL: https://github.com/apache/arrow/pull/10673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#issuecomment-877747590
Hmm, can it be that test times for the docker build went from 20 minutes to 50 minutes? (https://github.com/apache/arrow/runs/3005016709 vs https://github.com/apache/arrow/runs/3037021755).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#discussion_r665448616
##########
File path: js/jest.config.js
##########
@@ -45,7 +45,8 @@ module.exports = {
"^.+\\.tsx?$": "ts-jest"
},
"transformIgnorePatterns": [
- "/node_modules/(?!web-stream-tools).+\\.js$"
+ "/node_modules/(?!web-stream-tools).+\\.js$",
+ ".*/cjs/.*\\.js$"
Review comment:
Without this, I am getting this strange error when I run `yarn gulp test:es5:cjs`?
```
ts-jest[ts-compiler] (WARN) Unable to process '/Users/dominik/Code/arrow/js/targets/es5/cjs/io/adapters.js', falling back to original file content. You can also configure Jest config option `transformIgnorePatterns` to ignore /Users/dominik/Code/arrow/js/targets/es5/cjs/io/adapters.js from transformation or make sure that `outDir` in your tsconfig is neither `''` or `'.'`
```
Any idea what's causing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz edited a comment on pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript and refactor testing infrastructure
Posted by GitBox <gi...@apache.org>.
domoritz edited a comment on pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#issuecomment-877747590
~~Hmm, can it be that test times for the docker build went from 20 minutes to 50 minutes? (https://github.com/apache/arrow/runs/3005016709 vs https://github.com/apache/arrow/runs/3037021755).~~ The last run was faster again. Maybe the CI is just inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#discussion_r665669908
##########
File path: js/jest.config.js
##########
@@ -45,7 +45,8 @@ module.exports = {
"^.+\\.tsx?$": "ts-jest"
},
"transformIgnorePatterns": [
- "/node_modules/(?!web-stream-tools).+\\.js$"
+ "/node_modules/(?!web-stream-tools).+\\.js$",
+ ".*/cjs/.*\\.js$"
Review comment:
It looks like our setup is unhappy about having ts files right next to js files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10673: ARROW-13277: [JS] Add declaration maps for TypeScript
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10673:
URL: https://github.com/apache/arrow/pull/10673#discussion_r665669908
##########
File path: js/jest.config.js
##########
@@ -45,7 +45,8 @@ module.exports = {
"^.+\\.tsx?$": "ts-jest"
},
"transformIgnorePatterns": [
- "/node_modules/(?!web-stream-tools).+\\.js$"
+ "/node_modules/(?!web-stream-tools).+\\.js$",
+ ".*/cjs/.*\\.js$"
Review comment:
It looks like our setup is unhappy about having ts files right next to js files. I think I can redo this on top of #10371.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org