You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/06/03 15:49:11 UTC
Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in
subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
https://issues.apache.org/jira/browse/CLOUDSTACK-2651
This addresses bugs Cloudstack-2511 and Cloudstack-2651.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
Diff: https://reviews.apache.org/r/11600/diff/
Testing
-------
Tested with master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip
range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Posted by Abhinandan Prateek <ap...@apache.org>.
> On June 12, 2013, 5:53 a.m., Abhinandan Prateek wrote:
> > Ship It!
create enums for return values to signify the cidd overlap.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/#review21780
-----------------------------------------------------------
On June 4, 2013, 2:51 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11600/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 2:51 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
> https://issues.apache.org/jira/browse/CLOUDSTACK-2511
>
> Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet.
> https://issues.apache.org/jira/browse/CLOUDSTACK-2651
>
>
> This addresses bugs Cloudstack-2511 and Cloudstack-2651.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
> server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667
> utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
>
> Diff: https://reviews.apache.org/r/11600/diff/
>
>
> Testing
> -------
>
> Tested with master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip
range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/#review21780
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 4, 2013, 2:51 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11600/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 2:51 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
> https://issues.apache.org/jira/browse/CLOUDSTACK-2511
>
> Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet.
> https://issues.apache.org/jira/browse/CLOUDSTACK-2651
>
>
> This addresses bugs Cloudstack-2511 and Cloudstack-2651.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
> server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667
> utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
>
> Diff: https://reviews.apache.org/r/11600/diff/
>
>
> Testing
> -------
>
> Tested with master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip
range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Posted by bharat kumar <bh...@citrix.com>.
> On June 10, 2013, 4:23 p.m., Koushik Das wrote:
> > Don't combine multiple fixes in a single commit. Keep it simple -> 1 commit = 1 bug fix
These issues are closely related to each other and so i think combining them is not bad
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/#review21654
-----------------------------------------------------------
On June 4, 2013, 2:51 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11600/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 2:51 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
> https://issues.apache.org/jira/browse/CLOUDSTACK-2511
>
> Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet.
> https://issues.apache.org/jira/browse/CLOUDSTACK-2651
>
>
> This addresses bugs Cloudstack-2511 and Cloudstack-2651.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
> server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667
> utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
>
> Diff: https://reviews.apache.org/r/11600/diff/
>
>
> Testing
> -------
>
> Tested with master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip
range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/#review21654
-----------------------------------------------------------
Don't combine multiple fixes in a single commit. Keep it simple -> 1 commit = 1 bug fix
- Koushik Das
On June 4, 2013, 2:51 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11600/
> -----------------------------------------------------------
>
> (Updated June 4, 2013, 2:51 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
> https://issues.apache.org/jira/browse/CLOUDSTACK-2511
>
> Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet.
> https://issues.apache.org/jira/browse/CLOUDSTACK-2651
>
>
> This addresses bugs Cloudstack-2511 and Cloudstack-2651.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
> server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667
> utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
>
> Diff: https://reviews.apache.org/r/11600/diff/
>
>
> Testing
> -------
>
> Tested with master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip
range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511,
Cloudstack-2651 [Shared n/w]Add IP range should ask for gateway and netmask
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11600/
-----------------------------------------------------------
(Updated June 4, 2013, 2:51 p.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description (updated)
-------
Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset to existing CIDR is allowed
https://issues.apache.org/jira/browse/CLOUDSTACK-2511
Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and netmask while adding the ip range to the existing subnet.
https://issues.apache.org/jira/browse/CLOUDSTACK-2651
This addresses bugs Cloudstack-2511 and Cloudstack-2651.
Diffs (updated)
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf
server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667
utils/src/com/cloud/utils/net/NetUtils.java 8c094c8
Diff: https://reviews.apache.org/r/11600/diff/
Testing
-------
Tested with master.
Thanks,
bharat kumar