You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "jhiapple (via GitHub)" <gi...@apache.org> on 2023/06/22 14:41:15 UTC
[GitHub] [trafficserver] jhiapple opened a new pull request, #9899: Add doublequotes around the URL of X-Effective-URL.
jhiapple opened a new pull request, #9899:
URL: https://github.com/apache/trafficserver/pull/9899
URLs can have commas which makes the URLs fragile when multiple URLs are returned, and the values of multiple X-Effective-URL headers are merged.
Follow-up on 170e12b4 (Adds new X-Effective-URL header to the xdebug plugin (#7931))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jhiapple commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "jhiapple (via GitHub)" <gi...@apache.org>.
jhiapple commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603851514
> I suggest asking on the users mailing list if this would cause problems for anyone.
I'd be really surprised if anyone else than me is using the X-Effective-URL debug feature, which I added two years ago for a very particular use case I have.
Google search for
trafficserver "x-effective-url"
returns exactly two (2) hits, one in the 9.x "what's new" and one in the 9.2.0 changeling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1613150751
[approve ci clang-format]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1608476385
Note: the reason I suggested to back port this change to 9.2.x is that I think this is a bug (not just an enhancement). URLs that contain commas are problematic if those are in header values. See also the example on the RFC.
https://www.rfc-editor.org/rfc/rfc9110.html#name-field-values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] jhiapple commented on pull request #9899: For xdebug plugin, add doublequotes around the URL of X-Effective-URL.
Posted by "jhiapple (via GitHub)" <gi...@apache.org>.
jhiapple commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1637505522
Added documentation for the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603429795
I suggest asking on the users mailing list if this would cause problems for anyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603260570
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1611445562
Can you add documentation for this option in doc/admin-quide/plugins/xdebug.en.rst ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603262745
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603039278
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1623925770
This is the spec for a quoted string in an HTTP header field value: https://www.rfc-editor.org/rfc/rfc9110.html#name-quoted-strings
So, the only potential non-compliance would be if a double quote was in the URL (without being URL encoded as %22). Can we be sure this won't happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "ywkaras (via GitHub)" <gi...@apache.org>.
ywkaras commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1623970263
> Double-quote is one of unsafe characters, and "All unsafe characters must always be encoded within a URL" according to RFC1738. https://datatracker.ietf.org/doc/html/rfc1738#section-2.2
Presumably that means ATS would ignore a request with a non-escaped double quote in a URL component. But, if not, I supposed that would be an issue to handle in a separate PR.
However, we still have the issue that this is an undocumented feature of xdebug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1608403142
RFC on URL Encoding: https://datatracker.ietf.org/doc/html/rfc1738#section-2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1603294458
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1618858535
Not 100% sure this should go into 9.2.x, considering it does change behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #9899: For xdebug plugin, add doublequotes around the URL of X-Effective-URL.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9899: Add doublequotes around the URL of X-Effective-URL.
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9899:
URL: https://github.com/apache/trafficserver/pull/9899#issuecomment-1623942706
Double-quote is one of unsafe characters, and "All unsafe characters must always be encoded within a URL" according to RFC1738.
https://datatracker.ietf.org/doc/html/rfc1738#section-2.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org