You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/28 01:34:45 UTC

[GitHub] [incubator-mxnet] ZhennanQin commented on issue #16618: Fix GetMKLDNNData for delay alloc

ZhennanQin commented on issue #16618: Fix GetMKLDNNData for delay alloc
URL: https://github.com/apache/incubator-mxnet/pull/16618#issuecomment-546759180
 
 
   @marcoabreu Thanks for reviewing. This is to fix a bug reported at https://github.com/apache/incubator-mxnet/pull/16555#issuecomment-545892144. Basically, we can use the reported case as a test. But from the bug report, network is loaded from json file, which contains a subgraph. I don't know how to reproduce it with python symbol API. Do you agree with adding a test with loading network from json? Otherwise I need some expert's help to rewrite that into a test.
   
   For CI failure rate, this PR is based on master, not mkldnn-1.0. And as you seen, it already re-triggered for 5 times. I don't think it's a acceptable developer experience.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services