You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 13:50:10 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #23221: Ensure state is updated on task actions
bbovenzi opened a new pull request, #23221:
URL: https://github.com/apache/airflow/pull/23221
When the DAG was paused or autorefresh was off, there was no change when performing a task action. Making it look like it didn't work.
Fix: remove the `enabled` option to make sure that anytime the query is invalidated it does refetch data. But also, to prevent a refetch on load with `staleTime`
Also, updated the retry and refetch options to prevent excessive fetches.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23221: Ensure state is updated on task actions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23221:
URL: https://github.com/apache/airflow/pull/23221#issuecomment-1108657959
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] staufferl16 commented on pull request #23221: Ensure state is updated on task actions
Posted by GitBox <gi...@apache.org>.
staufferl16 commented on PR #23221:
URL: https://github.com/apache/airflow/pull/23221#issuecomment-1108659279
From a code standpoint, things look good to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #23221: Ensure state is updated on task actions
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #23221:
URL: https://github.com/apache/airflow/pull/23221#issuecomment-1108754982
Looks like tests are failing here though @bbovenzi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #23221: Ensure state is updated on task actions
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #23221:
URL: https://github.com/apache/airflow/pull/23221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org