You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/03/13 18:46:24 UTC

[GitHub] [ignite] Mmuzaf opened a new pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Mmuzaf opened a new pull request #8874:
URL: https://github.com/apache/ignite/pull/8874


   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594403189



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.lang.IgnitePredicate;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckEmptyCache() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, 0, key -> new Account(key, key),
+            txFilteredCache("indexed"));
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertTrue(F.isEmpty(res.exceptions()));
+    }
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckWithIndexes() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, CACHE_KEYS_RANGE, key -> new Account(key, key),
+            txFilteredCache("indexed"));
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertContains(log, b.toString(), "The check procedure has finished, no conflicts have been found.");
+    }
+
+    /** @throws Exception If failed. */
+    @Test
+    public void testClusterSnapshotCheckWithNodeFilter() throws Exception {
+        startGridsWithoutCache(2);
+
+        IgniteCache<Integer, Account> cache1 = grid(0).createCache(txFilteredCache("cache0")
+            .setNodeFilter(new SelfNodeFilter(grid(0).localNode().id())));
+        IgniteCache<Integer, Account> cache2 = grid(1).createCache(txFilteredCache("cache1")
+            .setNodeFilter(new SelfNodeFilter(grid(1).localNode().id())));
+
+        for (int i = 0; i < CACHE_KEYS_RANGE; i++) {
+            cache1.put(i, new Account(i, i));
+            cache2.put(i, new Account(i, i));
+        }
+
+        grid(0).snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = grid(0).context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertContains(log, b.toString(), "The check procedure has finished, no conflicts have been found.");
+    }
+
+    /** Node filter to run cache on single node. */
+    private static class SelfNodeFilter implements IgnitePredicate<ClusterNode> {

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] xtern commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594170449



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    private final CacheConfiguration<Integer, Account> indexedCcfg =
+        txCacheConfig(new CacheConfiguration<Integer, Account>("indexed"))
+            .setQueryEntities(singletonList(new QueryEntity(Integer.class.getName(), Account.class.getName())));
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckEmptyCache() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, 0, key -> new Account(key, key), indexedCcfg);
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get();
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertTrue(F.isEmpty(res.exceptions()));
+    }
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckWithIndexes() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, CACHE_KEYS_RANGE, key -> new Account(key, key), indexedCcfg);
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get();

Review comment:
       I suggest adding a short timeout for all places where we are waiting for something




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594225664



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMetadata.java
##########
@@ -137,7 +137,7 @@ public int pageSize() {
     }
 
     /**
-     * @return The list of cache groups ids which were included into snapshot.
+     * @return The list of cache groups ids which were included into the snapshot globally.

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] xtern commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594229692



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.apache.ignite.lang.IgnitePredicate;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckEmptyCache() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, 0, key -> new Account(key, key),
+            txFilteredCache("indexed"));
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertTrue(F.isEmpty(res.exceptions()));
+    }
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckWithIndexes() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, CACHE_KEYS_RANGE, key -> new Account(key, key),
+            txFilteredCache("indexed"));
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertContains(log, b.toString(), "The check procedure has finished, no conflicts have been found.");
+    }
+
+    /** @throws Exception If failed. */
+    @Test
+    public void testClusterSnapshotCheckWithNodeFilter() throws Exception {
+        startGridsWithoutCache(2);
+
+        IgniteCache<Integer, Account> cache1 = grid(0).createCache(txFilteredCache("cache0")
+            .setNodeFilter(new SelfNodeFilter(grid(0).localNode().id())));
+        IgniteCache<Integer, Account> cache2 = grid(1).createCache(txFilteredCache("cache1")
+            .setNodeFilter(new SelfNodeFilter(grid(1).localNode().id())));
+
+        for (int i = 0; i < CACHE_KEYS_RANGE; i++) {
+            cache1.put(i, new Account(i, i));
+            cache2.put(i, new Account(i, i));
+        }
+
+        grid(0).snapshot().createSnapshot(SNAPSHOT_NAME).get(SNAPSHOT_AWAIT_TIMEOUT_MS);
+
+        IdleVerifyResultV2 res = grid(0).context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertContains(log, b.toString(), "The check procedure has finished, no conflicts have been found.");
+    }
+
+    /** Node filter to run cache on single node. */
+    private static class SelfNodeFilter implements IgnitePredicate<ClusterNode> {

Review comment:
       SerialVersionUID is missing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] xtern commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594175406



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotMetadata.java
##########
@@ -137,7 +137,7 @@ public int pageSize() {
     }
 
     /**
-     * @return The list of cache groups ids which were included into snapshot.
+     * @return The list of cache groups ids which were included into the snapshot globally.

Review comment:
       "cache groups ids" can be changed to "cache group IDs"
   it's up to you, but I found the expression "cache group ids" only in snapshots 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf commented on pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#issuecomment-799315031


   @xtern I've fixed all your comments, please, take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
Mmuzaf commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594224568



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    private final CacheConfiguration<Integer, Account> indexedCcfg =

Review comment:
       Fixed.

##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    private final CacheConfiguration<Integer, Account> indexedCcfg =
+        txCacheConfig(new CacheConfiguration<Integer, Account>("indexed"))
+            .setQueryEntities(singletonList(new QueryEntity(Integer.class.getName(), Account.class.getName())));
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckEmptyCache() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, 0, key -> new Account(key, key), indexedCcfg);
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get();
+
+        IdleVerifyResultV2 res = ignite.context().cache().context().snapshotMgr().checkSnapshot(SNAPSHOT_NAME).get();
+
+        StringBuilder b = new StringBuilder();
+        res.print(b::append, true);
+
+        assertTrue("Exceptions: " + b, F.isEmpty(res.exceptions()));
+        assertTrue(F.isEmpty(res.exceptions()));
+    }
+
+    /** @throws Exception If fails. */
+    @Test
+    public void testClusterSnapshotCheckWithIndexes() throws Exception {
+        IgniteEx ignite = startGridsWithCache(3, CACHE_KEYS_RANGE, key -> new Account(key, key), indexedCcfg);
+
+        ignite.snapshot().createSnapshot(SNAPSHOT_NAME).get();

Review comment:
       Fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] xtern commented on a change in pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
xtern commented on a change in pull request #8874:
URL: https://github.com/apache/ignite/pull/8874#discussion_r594168961



##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotCheckWithIndexesTest.java
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache.persistence.snapshot;
+
+import java.util.UUID;
+import org.apache.ignite.IgniteCache;
+import org.apache.ignite.cache.CacheMode;
+import org.apache.ignite.cache.QueryEntity;
+import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.IgniteEx;
+import org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2;
+import org.apache.ignite.internal.util.typedef.F;
+import org.junit.Test;
+
+import static java.util.Collections.singletonList;
+import static org.apache.ignite.testframework.GridTestUtils.assertContains;
+
+/**
+ * Cluster-wide snapshot test check command with indexes.
+ */
+public class IgniteClusterSnapshotCheckWithIndexesTest extends AbstractSnapshotSelfTest {
+    private final CacheConfiguration<Integer, Account> indexedCcfg =

Review comment:
       javadoc is missing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] Mmuzaf merged pull request #8874: IGNITE-14305 Fix snapshot check command for indexes

Posted by GitBox <gi...@apache.org>.
Mmuzaf merged pull request #8874:
URL: https://github.com/apache/ignite/pull/8874


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org